[OLS-871] datacollection is off when there is no pull-secret

openshift / lightspeed-operator

Operator for the OpenShift Lightspeed Service

Apache License 2.0

6 stars 22 forks source link

[OLS-871] datacollection is off when there is no pull-secret #383

Closed xrajesh closed 2 months ago

xrajesh commented 2 months ago

Description

Make data collection is off when there is no pull-secret.

Type of change

[ ] Refactor
[ ] New feature
[ ] Bug fix
[ ] CVE fix
[ ] Optimization
[ ] Documentation Update
[ ] Configuration Update
[ ] Bump-up dependent library

Related Tickets & Documents

Related Issue #
Closes #

Checklist before requesting a review

[ ] I have performed a self-review of my code.
[ ] PR has passed all pre-merge test jobs.
[ ] If it is a core feature, I have added thorough tests.

Testing

Please provide detailed steps to perform tests related to this code change.
How were the fix/results from this change verified? Please provide relevant screenshots or results.

raptorsun commented 2 months ago

/lgtm /retest

xrajesh commented 2 months ago

/approve

xrajesh commented 2 months ago

/test "Red Hat Konflux"

openshift-ci[bot] commented 2 months ago

@xrajesh: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

/test bundle-e2e-4-15
/test bundle-e2e-4-16
/test ci-index-lightspeed-bundle-test
/test generate
/test images
/test lint
/test security
/test unit

Use /test all to run all jobs.

In response to [this](https://github.com/openshift/lightspeed-operator/pull/383#issuecomment-2341323574): >/retest "Red Hat Konflux" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

xrajesh commented 2 months ago

/retest

syedriko commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

@xrajesh: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

xrajesh commented 2 months ago

/approve /override "Red Hat Konflux / ols-enterprise-contract / lightspeed-operator"

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: xrajesh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/lightspeed-operator/blob/main/OWNERS)~~ [xrajesh] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

openshift-ci[bot] commented 2 months ago

@xrajesh: Overrode contexts on behalf of xrajesh: Red Hat Konflux / ols-enterprise-contract / lightspeed-operator

In response to [this](https://github.com/openshift/lightspeed-operator/pull/383#issuecomment-2341958272): >/approve >/override "Red Hat Konflux / ols-enterprise-contract / lightspeed-operator" Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.