OCPBUGS-36215: [release-4.16] fix leap file corner cases

vitus133 commented 4 months ago

This commit fixes various leap file corner cases and adds missing functionality:

Rehash the leapfile after setting the expiration time to 2036
Fix corner cases of leap event appearing in a different ways in the leap indication in the past or in the future + add unit tests
General cleanup and refactor for better testability

This is a manual cherry-pick of #316 /cc @aneeshkp @jzding @josephdrichard @nishant-parekh

openshift-ci-robot commented 4 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-36215, which is invalid:

expected the bug to target either version "4.16." or "openshift-4.16.", but it targets "4.17.0" instead
release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected Jira Issue OCPBUGS-36215 to depend on a bug targeting a version in 4.17.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/324): >This commit fixes various leap file corner cases and adds missing functionality: >1. Rehash the leapfile after setting the expiration time to 2036 >2. Fix corner cases of leap event appearing in a different ways in the leap indication in the past or in the future + add unit tests >3. General cleanup and refactor for better testability > >This is a manual cherry-pick of #316 >/cc @aneeshkp @jzding @josephdrichard @nishant-parekh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

vitus133 commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-36215, which is invalid:

release note text must be set and not match the template OR release note type must be set to "Release Note Not Required"
expected Jira Issue OCPBUGS-36215 to depend on a bug targeting a version in 4.17.0 and in one of the following states: MODIFIED, ON_QA, VERIFIED, but no dependents were found

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/324#issuecomment-2191966973): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

aneeshkp commented 4 months ago

/jira refresh

openshift-ci-robot commented 4 months ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-36215, which is invalid:

expected dependent Jira Issue OCPBUGS-35725 to be in one of the following states: VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA), but it is ON_QA instead

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/324#issuecomment-2214846623): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jzding, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/linuxptp-daemon/blob/release-4.16/OWNERS)~~ [jzding,vitus133] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment

vitus133 commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-36215, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug

* bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-35725](https://issues.redhat.com//browse/OCPBUGS-35725) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-35725](https://issues.redhat.com//browse/OCPBUGS-35725) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/324#issuecomment-2248394724): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

Bonnie-Block commented 3 months ago

/label cherry-pick-approved

aneeshkp commented 3 months ago

/label backport-risk-assessed

openshift-ci[bot] commented 3 months ago

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

openshift-ci-robot commented 3 months ago

@vitus133: Jira Issue OCPBUGS-36215: All pull requests linked via external trackers have merged:

openshift/linuxptp-daemon#324

Jira Issue OCPBUGS-36215 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/324): >This commit fixes various leap file corner cases and adds missing functionality: >1. Rehash the leapfile after setting the expiration time to 2036 >2. Fix corner cases of leap event appearing in a different ways in the leap indication in the past or in the future + add unit tests >3. General cleanup and refactor for better testability > >This is a manual cherry-pick of #316 >/cc @aneeshkp @jzding @josephdrichard @nishant-parekh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.

vitus133 commented 3 months ago

/cherrypick release-4.15

openshift-cherrypick-robot commented 3 months ago

@vitus133: Failed to get PR patch from GitHub. This PR will need to be manually cherrypicked.

Error message

status code 406 not one of [200], body: {"message":"Sorry, the diff exceeded the maximum number of lines (20000)","errors":[{"resource":"PullRequest","field":"diff","code":"too_large"}],"documentation_url":"https://docs.github.com/rest/pulls/pulls#get-a-pull-request","status":"406"}

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/324#issuecomment-2248652114): >/cherrypick release-4.15 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.

openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: linuxptp-daemon This PR has been included in build ose-linuxptp-daemon-container-v4.16.0-202407242006.p0.g7130727.assembly.stream.el9. All builds following this will include this PR.

openshift / linuxptp-daemon

OCPBUGS-36215: [release-4.16] fix leap file corner cases #324