search

openshift / linuxptp-daemon

Linuxptp daemon runs as kubernetes DaemonSet and manages linuxptp processes such as ptp4l, phc2sys and timemaster.
Apache License 2.0
28 stars 30 forks source link

OCPBUGS-35587: T-GM - ts2phc process restart doesn't update PTP syncState when the process recovered #336

Closed aneeshkp closed 3 months ago

aneeshkp commented 3 months ago

The ts2phc process termination only triggers FREERUN and doesn't recover back. This PR fixes this issue by sending the process status to the GM Event Decision Engine, which will mark T-GM as FREERUN. The event framework will use the PROCESS_DOWN indication to produce accurate events.

openshift-ci-robot commented 3 months ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-35587, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/336): >ts2phc process termination only triggers FREERUN and doesn't recover back . >This PR fixes this issue by sending process_status indication along with ts2phc and the event framework will use this indication to produce accurate events Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 months ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-35587, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/336): >The ts2phc process termination only triggers FREERUN and doesn't recover back. This PR fixes this issue by sending the process status to the GM Event Decision Engine, which will mark T-GM as FREERUN. The event framework will use the PROCESS_DOWN indication to produce accurate events. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/linuxptp-daemon/blob/master/OWNERS)~~ [aneeshkp,jzding] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD 4e9d7626330ec087dd2385b2e51bb17ed3051ead and 2 for PR HEAD 92c7f2dcf979a785ea33068ede9a1ffb997c9d2f in total

openshift-ci[bot] commented 3 months ago

@aneeshkp: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/security 92c7f2dcf979a785ea33068ede9a1ffb997c9d2f link false /test security

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 months ago

@aneeshkp: Jira Issue OCPBUGS-35587: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35587 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/336): >The ts2phc process termination only triggers FREERUN and doesn't recover back. This PR fixes this issue by sending the process status to the GM Event Decision Engine, which will mark T-GM as FREERUN. The event framework will use the PROCESS_DOWN indication to produce accurate events. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

Distgit: linuxptp-daemon This PR has been included in build ose-linuxptp-daemon-container-v4.17.0-202407230118.p0.g1345d88.assembly.stream.el9. All builds following this will include this PR.

aneeshkp commented 3 months ago

/jira backport release-4.16 release-4.15 release-4.14

aneeshkp commented 3 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 months ago

@aneeshkp: new pull request created: #337

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/336#issuecomment-2244962682): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.