search

openshift / linuxptp-daemon

Linuxptp daemon runs as kubernetes DaemonSet and manages linuxptp processes such as ptp4l, phc2sys and timemaster.
Apache License 2.0
28 stars 30 forks source link

OCPBUGS-37646: fix grandmaster settings #351

Closed vitus133 closed 1 month ago

vitus133 commented 2 months ago

This commit fixes grandmaster announce flags to be consistent with ITU-T 8275.1 /cc @aneeshkp @jzding @josephdrichard @nishant-parekh

openshift-ci-robot commented 2 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-37646, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/351): >This commit fixes grandmaster announce flags to be consistent with ITU-T 8275.1 >/cc @aneeshkp @jzding @josephdrichard @nishant-parekh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/linuxptp-daemon/blob/master/OWNERS)~~ [aneeshkp,vitus133] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 1 month ago

@vitus133: Jira Issue OCPBUGS-37646: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37646 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/351): >This commit fixes grandmaster announce flags to be consistent with ITU-T 8275.1 >/cc @aneeshkp @jzding @josephdrichard @nishant-parekh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: linuxptp-daemon This PR has been included in build ose-linuxptp-daemon-container-v4.18.0-202409251710.p0.g1ac35ec.assembly.stream.el9. All builds following this will include this PR.