search

openshift / linuxptp-daemon

Linuxptp daemon runs as kubernetes DaemonSet and manages linuxptp processes such as ptp4l, phc2sys and timemaster.
Apache License 2.0
28 stars 30 forks source link

OCPBUGS-39173: [release-4.16] leap event backport #354

Closed vitus133 closed 2 hours ago

vitus133 commented 2 months ago

This is a manual cherry-pick of #326, #342 and #358

/cc @aneeshkp @jzding @josephdrichard @nishant-parekh

openshift-ci[bot] commented 2 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci-robot commented 2 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-39173, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/354): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vitus133 commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-39173, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/354#issuecomment-2317255219): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
vitus133 commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-39173, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-39187](https://issues.redhat.com//browse/OCPBUGS-39187) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-39187](https://issues.redhat.com//browse/OCPBUGS-39187) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents
In response to [this](https://github.com/openshift/linuxptp-daemon/pull/354#issuecomment-2317259165): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-39173, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/354): >This is a manual cherry-pick of #326, #342 and #358 > >/cc @aneeshkp @jzding @josephdrichard @nishant-parekh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
Bonnie-Block commented 1 day ago

/label cherry-pick-approved

aneeshkp commented 3 hours ago

/label backport-risk-assessed

aneeshkp commented 3 hours ago

/lgtm

aneeshkp commented 3 hours ago

/jira refresh

openshift-ci-robot commented 3 hours ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-39173, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-39187](https://issues.redhat.com//browse/OCPBUGS-39187) is in the state Verified, which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-39187](https://issues.redhat.com//browse/OCPBUGS-39187) targets the "4.17.z" version, which is one of the valid target versions: 4.17.0, 4.17.z * bug has dependents
In response to [this](https://github.com/openshift/linuxptp-daemon/pull/354#issuecomment-2476754475): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 hours ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/linuxptp-daemon/blob/release-4.16/OWNERS)~~ [aneeshkp,vitus133] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aneeshkp commented 2 hours ago

/label backport-risk-assessed

openshift-ci-robot commented 2 hours ago

@vitus133: Jira Issue OCPBUGS-39173: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-39173 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/354): >This is a manual cherry-pick of #326, #342 and #358 > >/cc @aneeshkp @jzding @josephdrichard @nishant-parekh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.