openshift / linuxptp-daemon

Linuxptp daemon runs as kubernetes DaemonSet and manages linuxptp processes such as ptp4l, phc2sys and timemaster.
Apache License 2.0
28 stars 30 forks source link

OCPBUGS-39174: [release-4.15] add leap event handling #355

Open vitus133 opened 2 months ago

vitus133 commented 2 months ago

this commit adds leap event handling that includes following:

  1. Determine that current time is within -12h...1m from the leap
  2. Send PMC command (once) to indicate leap61 or leap 59 to the downstream architecture and
  3. Handle ts2phc time ambiguity

This is a manual cherry-pick of https://github.com/openshift/linuxptp-daemon/pull/326, https://github.com/openshift/linuxptp-daemon/pull/342 and https://github.com/openshift/linuxptp-daemon/pull/358

/cc @aneeshkp @jzding @josephdrichard @nishant-parekh

openshift-ci-robot commented 2 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-39174, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/355): >this commit adds leap event handling that includes following: >1. Determine that current time is within -12h...1m from the leap >2. Send PMC command (once) to indicate leap61 or leap 59 to the downstream architecture and >3. Handle ts2phc time ambiguity Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: vitus133

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/linuxptp-daemon/blob/release-4.15/OWNERS)~~ [vitus133] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 months ago

@vitus133: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@vitus133: This pull request references Jira Issue OCPBUGS-39174, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/355): >this commit adds leap event handling that includes following: >1. Determine that current time is within -12h...1m from the leap >2. Send PMC command (once) to indicate leap61 or leap 59 to the downstream architecture and >3. Handle ts2phc time ambiguity > >This is a manual cherry-pick of https://github.com/openshift/linuxptp-daemon/pull/326, https://github.com/openshift/linuxptp-daemon/pull/342 and https://github.com/openshift/linuxptp-daemon/pull/358 > >/cc @aneeshkp @jzding @josephdrichard @nishant-parekh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.