search

openshift / linuxptp-daemon

Linuxptp daemon runs as kubernetes DaemonSet and manages linuxptp processes such as ptp4l, phc2sys and timemaster.
Apache License 2.0
28 stars 30 forks source link

OCPBUGS-19838:PTP HW Clock Class after disabling NMEA sentences - Handle T-GM holdover #367

Closed aneeshkp closed 1 month ago

aneeshkp commented 2 months ago

Holdover Enabled when GNSS time source is lost : The operator will configure ts2phcOpts: "--ts2phc.holdover ( timer calculated from DPLL ) --servo_offset_threshold 99999999 --servo_num_offset_values 10" The holdover should timeout same time as DPLL , hence we calculate DPLL timer to configure ts2phc holdover timeout 

 --ts2phc.holdover : The holdover interval, specified in seconds.

When the ToD information stops working (e.g. GNSS receiver lost its fix), ts2phc is allowed for the specified interval to continue synchronizing the target clock as long as the servo is in the SERVO_LOCKED_STABLE state. The servo state needs be enabled by the servo_offset_threshold option. The holdover is not supported with the -a option and when ts2phc.extts_polarity is set to both. The default is 0 (disabled).

--servo_num_offset_values: The number of offset values considered in order to transition from the SERVO_LOCKED to the SERVO_LOCKED_STABLE state. The transition occurs once the last servo_num_offset_values offsets are all below the servo_offset_threshold value. The default value is 10. PTP Operator will set it to 99999 a large number to prevent switching

servo_offset_threshold : The offset threshold used in order to transition from the SERVO_LOCKED to the SERVO_LOCKED_STABLE state. The transition occurs once the last servo_num_offset_values offsets are all below the threshold value. The default value of offset_threshold is 0 (disabled). But this need to be enabled for holdover to work

openshift-ci-robot commented 2 months ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-19838, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/367): >Holdover Enabled when GNSS time source is lost : >The operator will configure ts2phcOpts: "--ts2phc.holdover ( timer calculated from DPLL ) --servo_offset_threshold 99999999 --servo_num_offset_values 10" >The holdover should timeout same time as DPLL , hence we calculate DPLL timer to configure ts2phc holdover timeout > > --ts2phc.holdover : The holdover interval, specified in seconds. When the ToD information stops working (e.g. GNSS receiver lost its fix), `ts2phc` is allowed for the specified interval to continue synchronizing the target clock as long as the servo is in the `SERVO_LOCKED_STABLE` state. The servo state needs be enabled by the `servo_offset_threshold` option. The holdover is not supported with the `-a` option and when `ts2phc.extts_polarity` is set to `both`. The default is 0 (disabled). > > --servo_num_offset_values: The number of offset values considered in order to transition from the `SERVO_LOCKED` to the `SERVO_LOCKED_STABLE` state. The transition occurs once the last `servo_num_offset_values` offsets are all below the `servo_offset_threshold` value. The default value is 10. PTP Operator will set it to 99999 a large number to prevent switching > >servo_offset_threshold : The offset threshold used in order to transition from the `SERVO_LOCKED` to the `SERVO_LOCKED_STABLE` state. The transition occurs once the last `servo_num_offset_values` offsets are all below the threshold value. The default value of offset_threshold is 0 (disabled). But this need to be enabled for holdover to work > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-19838, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (hhassid@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/367): >Holdover Enabled when GNSS time source is lost : >The operator will configure ts2phcOpts: "--ts2phc.holdover ( timer calculated from DPLL ) --servo_offset_threshold 99999999 --servo_num_offset_values 10" >The holdover should timeout same time as DPLL , hence we calculate DPLL timer to configure ts2phc holdover timeout > > --ts2phc.holdover : The holdover interval, specified in seconds. >When the ToD information stops working (e.g. GNSS receiver lost its fix), `ts2phc` is allowed for the specified interval to continue synchronizing the target clock as long as the servo is in the `SERVO_LOCKED_STABLE` state. >The servo state needs be enabled by the `servo_offset_threshold` option. The holdover is not supported with the `-a` option and when `ts2phc.extts_polarity` is set to `both`. The default is 0 (disabled). > > --servo_num_offset_values: The number of offset values considered in order to transition from the `SERVO_LOCKED` to the `SERVO_LOCKED_STABLE` state. The transition occurs once the last `servo_num_offset_values` offsets are all below the `servo_offset_threshold` value. The default value is 10. PTP Operator will set it to 99999 a large number to prevent switching > >servo_offset_threshold : The offset threshold used in order to transition from the `SERVO_LOCKED` to the `SERVO_LOCKED_STABLE` state. The transition occurs once the last `servo_num_offset_values` offsets are all below the threshold value. The default value of offset_threshold is 0 (disabled). But this need to be enabled for holdover to work > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aneeshkp commented 2 months ago

/test unit-test

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 6b9f4e90569d8d3c7b2fbd6991339f0bb1f60748 and 2 for PR HEAD f69fcda277a25e1beef7724775daec92e3ad5177 in total

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 6b9f4e90569d8d3c7b2fbd6991339f0bb1f60748 and 2 for PR HEAD f69fcda277a25e1beef7724775daec92e3ad5177 in total

openshift-ci[bot] commented 1 month ago

@aneeshkp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp, jzding

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/linuxptp-daemon/blob/master/OWNERS)~~ [aneeshkp,jzding] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

@aneeshkp: Jira Issue OCPBUGS-19838: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-19838 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/367): >Holdover Enabled when GNSS time source is lost : >The operator will configure ts2phcOpts: "--ts2phc.holdover ( timer calculated from DPLL ) --servo_offset_threshold 99999999 --servo_num_offset_values 10" >The holdover should timeout same time as DPLL , hence we calculate DPLL timer to configure ts2phc holdover timeout > > --ts2phc.holdover : The holdover interval, specified in seconds. >When the ToD information stops working (e.g. GNSS receiver lost its fix), `ts2phc` is allowed for the specified interval to continue synchronizing the target clock as long as the servo is in the `SERVO_LOCKED_STABLE` state. >The servo state needs be enabled by the `servo_offset_threshold` option. The holdover is not supported with the `-a` option and when `ts2phc.extts_polarity` is set to `both`. The default is 0 (disabled). > > --servo_num_offset_values: The number of offset values considered in order to transition from the `SERVO_LOCKED` to the `SERVO_LOCKED_STABLE` state. The transition occurs once the last `servo_num_offset_values` offsets are all below the `servo_offset_threshold` value. The default value is 10. PTP Operator will set it to 99999 a large number to prevent switching > >servo_offset_threshold : The offset threshold used in order to transition from the `SERVO_LOCKED` to the `SERVO_LOCKED_STABLE` state. The transition occurs once the last `servo_num_offset_values` offsets are all below the threshold value. The default value of offset_threshold is 0 (disabled). But this need to be enabled for holdover to work > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: linuxptp-daemon This PR has been included in build ose-linuxptp-daemon-container-v4.18.0-202409231909.p0.g7805c7f.assembly.stream.el9. All builds following this will include this PR.