search

openshift / linuxptp-daemon

Linuxptp daemon runs as kubernetes DaemonSet and manages linuxptp processes such as ptp4l, phc2sys and timemaster.
Apache License 2.0
28 stars 30 forks source link

Verify HW configuration to enable or disable T-GM Holdover #370

Open aneeshkp opened 4 weeks ago

aneeshkp commented 4 weeks ago

Added check to verify dependency and linter fixes

The dependency Checker iterates over the interfaces (p.ifaces) associated with the _ptpProcess. Checking for DPLL Requirement: For each interface, it checks if the source is either GNSS or PPS, AND if the process name is ts2phcProcessName. adds dpll.DPLL_PROCESSNAME to the deps map. Adding GPSD and GPSPIPE Dependencies: If the interface source is GNSS and the process name is ts2phcProcessName, it adds GPSD_PROCESSNAME and GPSPIPE_PROCESSNAME to the deps map

openshift-ci-robot commented 4 weeks ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-43442, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/370): >Added check to verify dependency and linter fixes > >The dependency Checker iterates over the interfaces (p.ifaces) associated with the _ptpProcess. >Checking for DPLL Requirement: > For each interface, it checks if the source is either GNSS or PPS, AND if the process name is ts2phcProcessName. >adds dpll.DPLL_PROCESSNAME to the deps map. >Adding GPSD and GPSPIPE Dependencies: > If the interface source is GNSS and the process name is ts2phcProcessName, it adds GPSD_PROCESSNAME and GPSPIPE_PROCESSNAME to the deps map Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: aneeshkp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/linuxptp-daemon/blob/master/OWNERS)~~ [aneeshkp] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
aneeshkp commented 4 weeks ago

/jira refresh

openshift-ci-robot commented 4 weeks ago

@aneeshkp: This pull request references Jira Issue OCPBUGS-43442, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.18.0) matches configured target version for branch (4.18.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (bblock@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/370#issuecomment-2417914548): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 4 weeks ago

@aneeshkp: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 weeks ago

@aneeshkp: No Jira issue is referenced in the title of this pull request. To reference a jira issue, add 'XYZ-NNN:' to the title of this pull request and request another refresh with /jira refresh.

In response to [this](https://github.com/openshift/linuxptp-daemon/pull/370): >Added check to verify dependency and linter fixes > >The dependency Checker iterates over the interfaces (p.ifaces) associated with the _ptpProcess. >Checking for DPLL Requirement: > For each interface, it checks if the source is either GNSS or PPS, AND if the process name is ts2phcProcessName. >adds dpll.DPLL_PROCESSNAME to the deps map. >Adding GPSD and GPSPIPE Dependencies: > If the interface source is GNSS and the process name is ts2phcProcessName, it adds GPSD_PROCESSNAME and GPSPIPE_PROCESSNAME to the deps map Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flinuxptp-daemon). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
aneeshkp commented 2 weeks ago

/hold

openshift-merge-robot commented 2 weeks ago

PR needs rebase.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.