search

openshift / local-storage-operator

Operator for local storage
Apache License 2.0
83 stars 71 forks source link

Running must-gather commands in background #464

Closed OdedViner closed 10 months ago

OdedViner commented 10 months ago

To save time when running the LSO MG, the collection must-gather commands can be executed in parallel.

We can compare the MG runtime with my fix and the regular image. I built a private image quay.io/oviner/ocs-must-gather:lso_mg

time oc adm must-gather --image=quay.io/oviner/ocs-must-gather:lso_mg
openshift-ci[bot] commented 10 months ago

Hi @OdedViner. Thanks for your PR.

I'm waiting for a openshift member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
mpatlasov commented 10 months ago

/ok-to-test

mpatlasov commented 10 months ago

/lgtm /approve

and see my "very minor nit" comment inline

openshift-ci[bot] commented 10 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mpatlasov, OdedViner

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/local-storage-operator/blob/master/OWNERS)~~ [mpatlasov] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 10 months ago

@OdedViner: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
jsafrane commented 10 months ago

/label px-approved /label docs-approved This change does not need any docs.

jsafrane commented 10 months ago

/label qe-approved Talked to QE on slack, they can do post-merge validation if necessary

openshift-bot commented 10 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-local-storage-mustgather-container-v4.16.0-202401162251.p0.g57c341a.assembly.stream for distgit local-storage-mustgather. All builds following this will include this PR.