search

openshift / local-storage-operator

Operator for local storage
Apache License 2.0
81 stars 70 forks source link

STOR-1827: Limit must-gather log collection by timestamps #476

Closed jsafrane closed 5 months ago

jsafrane commented 5 months ago

Use MUST_GATHER_SINCE and MUST_GATHER_SINCE_TIME env. vars to limit log collection. They are set by oc adm must-gather --since or --since-time.

Tested by:

oc adm must-gather --image=quay.io/jsafrane/scratch:mg4 --since-time=2024-04-10T10:16:25.762Z
oc adm must-gather --image=quay.io/jsafrane/scratch:mg4 --since=1h

This PR contains a partial copy of https://github.com/openshift/must-gather/blob/a175e0178104f4f794828c02245cd2de896cef0e/collection-scripts/common.sh, I haven't found a way how to share the script nicely.

@openshift/storage

openshift-ci-robot commented 5 months ago

@jsafrane: This pull request references STOR-1827 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/local-storage-operator/pull/476): >Use MUST_GATHER_SINCE and MUST_GATHER_SINCE_TIME env. vars to limit log collection. They are set by `oc adm must-gather --since` or `--since-time`. > >Tested by: >``` >oc adm must-gather --image=quay.io/jsafrane/scratch:mg4 --since-time=2024-04-10T10:16:25.762Z >oc adm must-gather --image=quay.io/jsafrane/scratch:mg4 --since=1h >``` > >This PR contains a partial copy of https://github.com/openshift/must-gather/blob/a175e0178104f4f794828c02245cd2de896cef0e/collection-scripts/common.sh, I haven't found a way how to share the script nicely. > >@openshift/storage > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flocal-storage-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 5 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/local-storage-operator/blob/master/OWNERS)~~ [jsafrane] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jsafrane commented 5 months ago

/label px-approved /label docs-approved

openshift-ci[bot] commented 5 months ago

@jsafrane: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-operator-extended cbad3b98d963d1ba00d8f2dcbc95ed4fc459ca8c link false /test e2e-operator-extended

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
dobsonj commented 5 months ago

/lgtm

duanwei33 commented 5 months ago

/label qe-approved

openshift-ci-robot commented 5 months ago

@jsafrane: This pull request references STOR-1827 which is a valid jira issue.

In response to [this](https://github.com/openshift/local-storage-operator/pull/476): >Use MUST_GATHER_SINCE and MUST_GATHER_SINCE_TIME env. vars to limit log collection. They are set by `oc adm must-gather --since` or `--since-time`. > >Tested by: >``` >oc adm must-gather --image=quay.io/jsafrane/scratch:mg4 --since-time=2024-04-10T10:16:25.762Z >oc adm must-gather --image=quay.io/jsafrane/scratch:mg4 --since=1h >``` > >This PR contains a partial copy of https://github.com/openshift/must-gather/blob/a175e0178104f4f794828c02245cd2de896cef0e/collection-scripts/common.sh, I haven't found a way how to share the script nicely. > >@openshift/storage > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flocal-storage-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 5 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build local-storage-diskmaker-container-v4.16.0-202404121144.p0.g342d140.assembly.stream.el9 for distgit local-storage-diskmaker. All builds following this will include this PR.