openshift / lvm-operator

The LVM Operator deploys and manages LVM storage on OpenShift clusters
Apache License 2.0
43 stars 40 forks source link

OCPEDGE-825: Konflux branch merge #761

Closed jeff-roche closed 3 weeks ago

jeff-roche commented 3 weeks ago

Merges main-rhtap branch to main with the changes needed to reflect the branch change as well as updated links to the quay repos after re-onboarding the konflux components

openshift-ci-robot commented 3 weeks ago

@jeff-roche: This pull request references OCPEDGE-825 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.16" instead.

In response to [this](https://github.com/openshift/lvm-operator/pull/761): >Merges `main-rhtap` branch to `main` with the changes needed to reflect the branch change as well as updated links to the quay repos after re-onboarding the konflux components Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flvm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/lvm-operator/blob/main/OWNERS)~~ [jeff-roche] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jeff-roche commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@jeff-roche: This pull request references OCPEDGE-825 which is a valid jira issue.

In response to [this](https://github.com/openshift/lvm-operator/pull/761#issuecomment-2426390220): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flvm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jeff-roche commented 3 weeks ago

/assign @suleymanakbas91

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 57.61%. Comparing base (7d3ceed) to head (31f133f). Report is 69 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/lvm-operator/pull/761/graphs/tree.svg?width=650&height=150&src=pr&token=cdwt37yFlJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/lvm-operator/pull/761?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## main #761 +/- ## ========================================== - Coverage 57.74% 57.61% -0.14% ========================================== Files 53 57 +4 Lines 4215 4480 +265 ========================================== + Hits 2434 2581 +147 - Misses 1536 1636 +100 - Partials 245 263 +18 ``` [see 25 files with indirect coverage changes](https://app.codecov.io/gh/openshift/lvm-operator/pull/761/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
openshift-ci[bot] commented 3 weeks ago

@jeff-roche: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
suleymanakbas91 commented 3 weeks ago

/lgtm