openshift / lvm-operator

The LVM Operator deploys and manages LVM storage on OpenShift clusters
Apache License 2.0
43 stars 40 forks source link

OCPEDGE-824: Adjust bundle to resemble released bundles #764

Closed suleymanakbas91 closed 3 weeks ago

openshift-ci-robot commented 3 weeks ago

@suleymanakbas91: This pull request references OCPEDGE-824 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target either version "4.18." or "openshift-4.18.", but it targets "openshift-4.17" instead.

In response to [this](https://github.com/openshift/lvm-operator/pull/764): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flvm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

suleymanakbas91 commented 3 weeks ago

/retest

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jeff-roche, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/lvm-operator/blob/main/OWNERS)~~ [jeff-roche,suleymanakbas91] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
jeff-roche commented 3 weeks ago

/lgtm

codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 68.78%. Comparing base (5491e77) to head (e97dc27). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/lvm-operator/pull/764/graphs/tree.svg?width=650&height=150&src=pr&token=cdwt37yFlJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/lvm-operator/pull/764?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## main #764 +/- ## ========================================== - Coverage 69.57% 68.78% -0.80% ========================================== Files 49 49 Lines 3415 3415 ========================================== - Hits 2376 2349 -27 - Misses 857 879 +22 - Partials 182 187 +5 ``` [see 6 files with indirect coverage changes](https://app.codecov.io/gh/openshift/lvm-operator/pull/764/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
suleymanakbas91 commented 3 weeks ago

/retest

openshift-ci[bot] commented 3 weeks ago

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).