openshift / lvm-operator

The LVM Operator deploys and manages LVM storage on OpenShift clusters
Apache License 2.0
43 stars 40 forks source link

NO-JIRA: chore: remove deprecated infrastructure-features annotation #773

Closed suleymanakbas91 closed 3 weeks ago

suleymanakbas91 commented 3 weeks ago

Removing the deprecated operators.openshift.io/infrastructure-features annotation as per https://github.com/openshift/openshift-docs/blob/main/modules/osdk-csv-annotations-dep.adoc#deprecated-infrastructure-feature-annotations.

openshift-ci-robot commented 3 weeks ago

@suleymanakbas91: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/lvm-operator/pull/773): >Removing the deprecated `operators.openshift.io/infrastructure-features` annotation as per https://github.com/openshift/openshift-docs/blob/main/modules/osdk-csv-annotations-dep.adoc#deprecated-infrastructure-feature-annotations. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flvm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
jeff-roche commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/lvm-operator/blob/main/OWNERS)~~ [suleymanakbas91] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
codecov-commenter commented 3 weeks ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 69.51%. Comparing base (1ec2785) to head (5571b85). Report is 2 commits behind head on main.

Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/lvm-operator/pull/773/graphs/tree.svg?width=650&height=150&src=pr&token=cdwt37yFlJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/lvm-operator/pull/773?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## main #773 +/- ## ========================================== - Coverage 69.63% 69.51% -0.12% ========================================== Files 49 49 Lines 3415 3415 ========================================== - Hits 2378 2374 -4 - Misses 856 860 +4 Partials 181 181 ``` [see 4 files with indirect coverage changes](https://app.codecov.io/gh/openshift/lvm-operator/pull/773/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
jeff-roche commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

@suleymanakbas91: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).