openshift / lvm-operator

The LVM Operator deploys and manages LVM storage on OpenShift clusters
Apache License 2.0
43 stars 40 forks source link

[release-4.17] OCPBUGS-44440: Add migration logic for wipe refactor #781

Closed openshift-cherrypick-robot closed 4 days ago

openshift-cherrypick-robot commented 4 days ago

This is an automated cherry-pick of #779

/assign suleymanakbas91

openshift-ci-robot commented 4 days ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-44377 has been cloned as Jira Issue OCPBUGS-44440. Will retitle bug to link to clone. /retitle [release-4.17] OCPBUGS-44440: Add migration logic for wipe refactor

In response to [this](https://github.com/openshift/lvm-operator/pull/781): >This is an automated cherry-pick of #779 > >/assign suleymanakbas91 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flvm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 4 days ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-44440, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/lvm-operator/pull/781): >This is an automated cherry-pick of #779 > >/assign suleymanakbas91 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flvm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
codecov-commenter commented 4 days ago

Codecov Report

Attention: Patch coverage is 77.77778% with 8 lines in your changes missing coverage. Please review.

Project coverage is 70.84%. Comparing base (bc5e556) to head (227d67c).

Files with missing lines Patch % Lines
internal/migration/wipe-refactor/annotate.go 77.77% 4 Missing and 4 partials :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/lvm-operator/pull/781/graphs/tree.svg?width=650&height=150&src=pr&token=cdwt37yFlJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/lvm-operator/pull/781?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.17 #781 +/- ## ================================================ + Coverage 70.71% 70.84% +0.13% ================================================ Files 48 49 +1 Lines 3288 3324 +36 ================================================ + Hits 2325 2355 +30 - Misses 792 795 +3 - Partials 171 174 +3 ``` | [Flag](https://app.codecov.io/gh/openshift/lvm-operator/pull/781/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [](https://app.codecov.io/gh/openshift/lvm-operator/pull/781/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | `?` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#carryforward-flags-in-the-pull-request-comment) to find out more. | [Files with missing lines](https://app.codecov.io/gh/openshift/lvm-operator/pull/781?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [internal/migration/wipe-refactor/annotate.go](https://app.codecov.io/gh/openshift/lvm-operator/pull/781?src=pr&el=tree&filepath=internal%2Fmigration%2Fwipe-refactor%2Fannotate.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-aW50ZXJuYWwvbWlncmF0aW9uL3dpcGUtcmVmYWN0b3IvYW5ub3RhdGUuZ28=) | `77.77% <77.77%> (ø)` | | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/lvm-operator/pull/781/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
suleymanakbas91 commented 4 days ago

/retest

suleymanakbas91 commented 4 days ago

/lgtm /approve

openshift-ci[bot] commented 4 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/lvm-operator/blob/release-4.17/OWNERS)~~ [suleymanakbas91] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 4 days ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 4 days ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-44440: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44440 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/lvm-operator/pull/781): >This is an automated cherry-pick of #779 > >/assign suleymanakbas91 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flvm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
suleymanakbas91 commented 3 days ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 days ago

@suleymanakbas91: #781 failed to apply on top of branch "release-4.16":

Applying: fix: add a migration logic for wipe refactor
Using index info to reconstruct a base tree...
M   cmd/operator/operator.go
Falling back to patching base and 3-way merge...
Auto-merging cmd/operator/operator.go
CONFLICT (content): Merge conflict in cmd/operator/operator.go
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
hint: When you have resolved this problem, run "git am --continue".
hint: If you prefer to skip this patch, run "git am --skip" instead.
hint: To restore the original branch and stop patching, run "git am --abort".
hint: Disable this message with "git config advice.mergeConflict false"
Patch failed at 0001 fix: add a migration logic for wipe refactor
In response to [this](https://github.com/openshift/lvm-operator/pull/781#issuecomment-2470788608): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.