openshift / lvm-operator

The LVM Operator deploys and manages LVM storage on OpenShift clusters
Apache License 2.0
43 stars 40 forks source link

[release-4.17] OCPBUGS-44489: A non-resolvable device path causes all the devices to be excluded #785

Closed openshift-cherrypick-robot closed 2 days ago

openshift-cherrypick-robot commented 3 days ago

This is an automated cherry-pick of #782

/assign suleymanakbas91

openshift-ci-robot commented 3 days ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-43910 has been cloned as Jira Issue OCPBUGS-44489. Will retitle bug to link to clone. /retitle [release-4.17] OCPBUGS-44489: A non-resolvable device path causes all the devices to be excluded

In response to [this](https://github.com/openshift/lvm-operator/pull/785): >This is an automated cherry-pick of #782 > >/assign suleymanakbas91 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flvm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 days ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-44489, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/lvm-operator/pull/785): >This is an automated cherry-pick of #782 > >/assign suleymanakbas91 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flvm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
suleymanakbas91 commented 3 days ago

/lgtm /approve

openshift-ci[bot] commented 3 days ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, suleymanakbas91

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/lvm-operator/blob/release-4.17/OWNERS)~~ [suleymanakbas91] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
suleymanakbas91 commented 3 days ago

/retest

codecov-commenter commented 3 days ago

Codecov Report

Attention: Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.

Project coverage is 70.98%. Comparing base (6a0241a) to head (7a829fd).

Files with missing lines Patch % Lines
internal/controllers/vgmanager/filter/filter.go 60.00% 2 Missing :warning:
Additional details and impacted files [![Impacted file tree graph](https://app.codecov.io/gh/openshift/lvm-operator/pull/785/graphs/tree.svg?width=650&height=150&src=pr&token=cdwt37yFlJ&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)](https://app.codecov.io/gh/openshift/lvm-operator/pull/785?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) ```diff @@ Coverage Diff @@ ## release-4.17 #785 +/- ## ================================================ - Coverage 71.05% 70.98% -0.08% ================================================ Files 49 49 Lines 3324 3326 +2 ================================================ - Hits 2362 2361 -1 - Misses 791 793 +2 - Partials 171 172 +1 ``` | [Files with missing lines](https://app.codecov.io/gh/openshift/lvm-operator/pull/785?dropdown=coverage&src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift) | Coverage Δ | | |---|---|---| | [internal/controllers/vgmanager/controller.go](https://app.codecov.io/gh/openshift/lvm-operator/pull/785?src=pr&el=tree&filepath=internal%2Fcontrollers%2Fvgmanager%2Fcontroller.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-aW50ZXJuYWwvY29udHJvbGxlcnMvdmdtYW5hZ2VyL2NvbnRyb2xsZXIuZ28=) | `71.60% <100.00%> (ø)` | | | [internal/controllers/vgmanager/filter/filter.go](https://app.codecov.io/gh/openshift/lvm-operator/pull/785?src=pr&el=tree&filepath=internal%2Fcontrollers%2Fvgmanager%2Ffilter%2Ffilter.go&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift#diff-aW50ZXJuYWwvY29udHJvbGxlcnMvdmdtYW5hZ2VyL2ZpbHRlci9maWx0ZXIuZ28=) | `81.42% <60.00%> (-0.93%)` | :arrow_down: | ... and [1 file with indirect coverage changes](https://app.codecov.io/gh/openshift/lvm-operator/pull/785/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=openshift)
suleymanakbas91 commented 2 days ago

/retest

openshift-ci[bot] commented 2 days ago

@openshift-cherrypick-robot: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 days ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-44489: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-44489 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/lvm-operator/pull/785): >This is an automated cherry-pick of #782 > >/assign suleymanakbas91 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Flvm-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.