search

openshift / machine-api-operator

Machine API operator
Apache License 2.0
164 stars 203 forks source link

Precedence in Cloud Identification #522

Closed srirammageswaran8 closed 3 years ago

srirammageswaran8 commented 4 years ago

The machine api now is getting the cloud it is running in infrastructure object.

https://github.com/openshift/machine-api-operator/blob/master/pkg/operator/operator.go#L253-L258

https://github.com/openshift/machine-api-operator/blob/94398d11715b820f0bd79377b3cc702754f2ea02/pkg/operator/config.go#L63-L68

Can it be configured to be read from a config map and default to the infrastructure Object .?

This would be help full in bare metal install in any cloud which wants to use machines and machinesets.?

openshift-bot commented 4 years ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 3 years ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 3 years ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci-robot commented 3 years ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/machine-api-operator/issues/522#issuecomment-737111114): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.