search

openshift / machine-api-provider-ibmcloud

Apache License 2.0
0 stars 12 forks source link

CORS-2387: IBMCloud: Add NetworkResourceGroup #12

Closed cjschaef closed 1 year ago

cjschaef commented 1 year ago

Add support for a NetworkResourceGroup in the MachineProviderSpec, and the logic for performing lookups during a machine creation for IBM Cloud.

Related: https://issues.redhat.com/browse/CORS-2387

cjschaef commented 1 year ago

/retest

lobziik commented 1 year ago

/lgtm

cjschaef commented 1 year ago

e2e-ibmcloud failure appears to be an issue with the RHCOS image (checksum)

 level=info msg=Obtaining RHCOS image file from 'https://rhcos.mirror.openshift.com/art/storage/releases/rhcos-4.12/412.86.202209302317-0/x86_64/rhcos-412.86.202209302317-0-ibmcloud.x86_64.qcow2.gz?sha256=c96eeeb364f0b36d254fbb04378ed593f056fd69e57a1c7f152fb778e3a63696'
level=fatal msg=failed to fetch Terraform Variables: failed to generate asset "Terraform Variables": failed to get ibmcloud Terraform variables: failed to use cached ibmcloud image: gzip: invalid checksum
Setup phase finished, prepare env for next steps

Hopefully just a flake with that image/download/checksum. /retest

JoelSpeed commented 1 year ago

/approve

Looks good

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-api-provider-ibmcloud/blob/main/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 year ago

/retest-required

Remaining retests: 0 against base HEAD bc112f3bf46b17c9f9745fb60c87571c8cdaf8e9 and 2 for PR HEAD c09540f5b155c14518e3e663b58f744b1e75204b in total

cjschaef commented 1 year ago

e2e-ibmcloud was a Conformance failure

Suite run returned error: failed because an invariant was violated, 1255 pass, 1796 skip (48m25s)
error: failed because an invariant was violated, 1255 pass, 1796 skip (48m25s)

Monitoring until it does pass.

openshift-ci[bot] commented 1 year ago

@cjschaef: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud c09540f5b155c14518e3e663b58f744b1e75204b link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).