OCPCLOUD-1770: IBMCloud: Use public machine phases

[cjschaef]

Use the public consts for machine phases for consistency.

Related: https://issues.redhat.com/browse/OCPCLOUD-1770

Requires: https://github.com/openshift/api/pull/1358

[cjschaef]

Requires API changes to merge so the go mod can be updated properly. /hold

[cjschaef]

~This requires changes to the openshift/api to be merged first, so we can properly update the go modules, rather than overriding the api module to my fork.~ ~/hold~ Oops, guess my page hadn't refreshed, since I didn't see the comment above already doing this https://github.com/openshift/machine-api-provider-ibmcloud/pull/13#issuecomment-1325574373

[cjschaef]

https://github.com/openshift/api/pull/1358 has merged. I will rebase and update go mod

Done

[cjschaef]

e2e-ibmcloud looks to have a Conformance test failure

 Failing tests:
[sig-arch] Managed cluster should ensure platform components have system-* priority class associated [Suite:openshift/conformance/parallel] 

Dec  1 19:35:51.469: FAIL: 
3 pods found with invalid priority class (should be openshift-user-critical or begin with system-):
openshift-multus/cni-sysctl-allowlist-ds-m9hvp (currently "")
openshift-multus/cni-sysctl-allowlist-ds-vxkfp (currently "")
openshift-multus/cni-sysctl-allowlist-ds-zqsnv (currently "")

Unrelated to IBM MAPI. /retest

[cjschaef]

Rebase completed after local testing. Linting looks good, should be ready for review now. /unhold

[openshift-ci[bot]]

@cjschaef: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).

[JoelSpeed]

/approve

[openshift-ci[bot]]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-api-provider-ibmcloud/blob/main/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment