openshift / machine-api-provider-ibmcloud

Apache License 2.0
0 stars 12 forks source link

Updating ose-ibmcloud-machine-controllers images to be consistent with ART #14

Closed openshift-bot closed 1 year ago

openshift-bot commented 1 year ago

Updating ose-ibmcloud-machine-controllers images to be consistent with ART TLDR: Component owners, please ensure that this PR merges as it impacts the fidelity of your CI signal. Patch-manager / leads, this PR is a no-op from a product perspective -- feel free to manually apply any labels (e.g. jira/valid-bug) to help the PR merge as long as tests are passing. If the PR is labeled "needs-ok-to-test", this is to limit costs for re-testing these PRs while they wait for review. Issue /ok-to-test to remove this tag and help the PR to merge.

Detail: This repository is out of sync with the downstream product builds for this component. One or more images differ from those being used by ART to create product builds. This should be addressed to ensure that the component's CI testing is accurately reflecting what customers will experience.

The information within the following ART component metadata is driving this alignment request: ose-ibmcloud-machine-controllers.yml.

The vast majority of these PRs are opened because a different Golang version is being used to build the downstream component. ART compiles most components with the version of Golang being used by the control plane for a given OpenShift release. Exceptions to this convention (i.e. you believe your component must be compiled with a Golang version independent from the control plane) must be granted by the OpenShift architecture team and communicated to the ART team.

Roles & Responsibilities:

ART has been configured to reconcile your CI build root image (see https://docs.ci.openshift.org/docs/architecture/ci-operator/#build-root-image). In order for your upstream .ci-operator.yaml configuration to be honored, you must set the following in your openshift/release ci-operator configuration file:

build_root:
  from_repository: true

If you have any questions about this pull request, please reach out to @release-artists in the #aos-art coreos slack channel.

lobziik commented 1 year ago

/approve

openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-api-provider-ibmcloud/blob/main/OWNERS)~~ [lobziik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JoelSpeed commented 1 year ago

/lgtm

JoelSpeed commented 1 year ago

/skip

openshift-ci-robot commented 1 year ago

/retest-required

Remaining retests: 0 against base HEAD 9b7f3ad4d9efbba5c0734ae3d24155ecefe49d51 and 2 for PR HEAD 02e1dc8064689aea4f12b6d50215e12c4aeb1229 in total

JoelSpeed commented 1 year ago

/retest-required

JoelSpeed commented 1 year ago

/retest-required

openshift-ci[bot] commented 1 year ago

@openshift-bot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud 02e1dc8064689aea4f12b6d50215e12c4aeb1229 link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
JoelSpeed commented 1 year ago

/override ci/prow/e2e-aws

We should remove AWS as a required job here now that the IBM job is working as expected

openshift-ci[bot] commented 1 year ago

@JoelSpeed: Overrode contexts on behalf of JoelSpeed: ci/prow/e2e-aws

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/14#issuecomment-1401715084): >/override ci/prow/e2e-aws > >We should remove AWS as a required job here now that the IBM job is working as expected Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.