search

openshift / machine-api-provider-ibmcloud

Apache License 2.0
0 stars 12 forks source link

OCPBUGS-6419: Update dependencies for kubernetes 1.26 #16

Closed elmiko closed 1 year ago

elmiko commented 1 year ago

this change consists of 2 commits, the first is to bump ginkgo to version 2 which is needed by the changes in controller-runtime for version 0.14 which will come with the kubernetes bump. the second commit is the bump to kubernetes dependencies.

openshift-ci-robot commented 1 year ago

@elmiko: This pull request references Jira Issue OCPBUGS-6419, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.13.0) matches configured target version for branch (4.13.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @huali9

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/16): >this change consists of 2 commits, the first is to bump ginkgo to version 2 which is needed by the changes in controller-runtime for version 0.14 which will come with the kubernetes bump. the second commit is the bump to kubernetes dependencies. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 year ago

@elmiko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud bd7aa058e31bc77dbd1e975d77365f1513675268 link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci[bot] commented 1 year ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lobziik

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-api-provider-ibmcloud/blob/main/OWNERS)~~ [lobziik] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
elmiko commented 1 year ago

i checked for the dynamic-resource-allocation dependency, this repo does not have that dependency.

RadekManak commented 1 year ago

/lgtm

openshift-ci-robot commented 1 year ago

@elmiko: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-6419 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/16): >this change consists of 2 commits, the first is to bump ginkgo to version 2 which is needed by the changes in controller-runtime for version 0.14 which will come with the kubernetes bump. the second commit is the bump to kubernetes dependencies. Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.