search

openshift / machine-api-provider-ibmcloud

Apache License 2.0
0 stars 12 forks source link

OCPCLOUD-2264: IBMCloud: Add boot volume key support #27

Closed cjschaef closed 10 months ago

cjschaef commented 11 months ago

Added a boot volume and encryption key field to the IBMCloudMachineProviderSpec, to allow machines to specify a boot volume encryption key. And added support to specify boot volume encryption key during machine creation.

Related: https://issues.redhat.com//browse/OCPCLOUD-2263 Related: https://issues.redhat.com//browse/OCPCLOUD-2264

JoelSpeed commented 10 months ago

/lgtm

Machines all look to be in the correct shape even though there's a storage failure, I think that is unrelated

gnufied commented 10 months ago

/retest

jsafrane commented 10 months ago

IBM failures are unrelated to the PR, we're struggling with something using wrong RHEL version for the CSI driver. Feel free to merge this with IBM failing this way.

jsafrane commented 10 months ago

/test images

jsafrane commented 10 months ago

/test e2e-ibmcloud

I'm just checking if regenerated images from a fresh CI image stream has pulled a better version of the CSI driver image. Feel free to ignore.

jeffnowicki commented 10 months ago

/remove-hold

openshift-bot commented 10 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ibmcloud-machine-controllers-container-v4.15.0-202312071813.p0.g6b0b8ea.assembly.stream for distgit ose-ibmcloud-machine-controllers. All builds following this will include this PR.