openshift / machine-api-provider-ibmcloud

Apache License 2.0
0 stars 12 forks source link

OCPCLOUD-2266: IBMCloud: MAPI Service Endpoint overrides #28

Closed cjschaef closed 9 months ago

cjschaef commented 10 months ago

Enable MAPI to override IBM Cloud Service endpoints from the Infrastructure config.

Related: https://issues.redhat.com/browse/OCPCLOUD-2266

openshift-ci-robot commented 10 months ago

@cjschaef: This pull request references OCPCLOUD-2266 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.15.0" version, but no target version was set.

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/28): >Enable MAPI to override IBM Cloud Service endpoints from the >Infrastructure config. > >Related: https://issues.redhat.com/browse/OCPCLOUD-2266 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 9 months ago

@cjschaef: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud 1dda3294e254f71bfd1432456b94e4fb153ee990 link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
JoelSpeed commented 9 months ago

/approve /lgtm

openshift-ci[bot] commented 9 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-api-provider-ibmcloud/blob/main/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 9 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ibmcloud-machine-controllers-container-v4.15.0-202311141432.p0.g2bcc500.assembly.stream for distgit ose-ibmcloud-machine-controllers. All builds following this will include this PR.