openshift / machine-api-provider-ibmcloud

Apache License 2.0
0 stars 12 forks source link

Default version when one isn't available #3

Closed cjschaef closed 2 years ago

cjschaef commented 2 years ago

Default the version of the package when one cannot be calculated from Git tags/commits.

cjschaef commented 2 years ago

e2e-ibmcloud test successfully create an IPI cluster, using this fix to address the known issue with machine-api-provider-ibmcloud image version in the CI.

 INFO[2022-08-02T15:14:42Z] Running step e2e-ibmcloud-ipi-install-install. 
INFO[2022-08-02T15:53:42Z] Step e2e-ibmcloud-ipi-install-install succeeded after 39m0s. 
INFO[2022-08-02T15:53:42Z] Running step e2e-ibmcloud-ipi-install-times-collection. 
INFO[2022-08-02T15:54:02Z] Step e2e-ibmcloud-ipi-install-times-collection succeeded after 20s. 
INFO[2022-08-02T15:54:02Z] Step phase pre succeeded after 41m10s.

Failure was on OCP Conformance testing, which is a known issue yet to be resolved.

JoelSpeed commented 2 years ago

We don't seem to have the approve plugin enabled here and I don't have permissions to merge on this repo (I normally would do, hmm), so we are going to need tide and the approve plugin set up to merge this

JoelSpeed commented 2 years ago

/retest

Karthik-K-N commented 2 years ago

/retest

cjschaef commented 2 years ago

tide and automation should now be enabled for this repo.

I'll retrigger the tests, and hopefully we can get this merged soon to fix the CI for all other IBM Cloud PR's

/retest-required

cjschaef commented 2 years ago

/test e2e-ibmcloud

cjschaef commented 2 years ago

e2e-aws-serial failure doesn't look to be related, since this is an IBMCloud repo. e2e-ibmcloud failure is due to failed OCP Conformance tests (which is expected), but the cluster creation was successful, with this patch.

 Suite run returned error: 3 fail, 1361 pass, 1744 skip (53m53s)
error: 3 fail, 1361 pass, 1744 skip (53m53s)
Shutting down SimultaneousPodIPControllerSimultaneousPodIPController shut down{"component":"entrypoint","error":"wrapped process failed: exit status 1","file":"k8s.io/test-infra/prow/entrypoint/run.go:80","func":"k8s.io/test-infra/prow/entrypoint.Options.Run","level":"error","msg":"Error executing test process","severity":"error","time":"2022-08-04T16:58:42Z"}
error: failed to execute wrapped command: exit status 1 
INFO[2022-08-04T16:58:52Z] Step e2e-ibmcloud-openshift-e2e-test failed after 1h2m2s. 
JoelSpeed commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: elmiko, JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-api-provider-ibmcloud/blob/main/OWNERS)~~ [JoelSpeed,elmiko] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 years ago

/retest-required

Remaining retests: 2 against base HEAD 170744c743d6d57500b45f4bc3e5f12856792913 and 8 for PR HEAD 0a5342a937f34ac558999ba60512c81f6f39e1cb in total

openshift-ci-robot commented 2 years ago

/retest-required

Remaining retests: 2 against base HEAD 170744c743d6d57500b45f4bc3e5f12856792913 and 8 for PR HEAD 0a5342a937f34ac558999ba60512c81f6f39e1cb in total

openshift-ci-robot commented 2 years ago

/retest-required

Remaining retests: 1 against base HEAD 170744c743d6d57500b45f4bc3e5f12856792913 and 7 for PR HEAD 0a5342a937f34ac558999ba60512c81f6f39e1cb in total

openshift-ci[bot] commented 2 years ago

@cjschaef: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud 0a5342a937f34ac558999ba60512c81f6f39e1cb link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 years ago

/retest-required

Remaining retests: 0 against base HEAD 170744c743d6d57500b45f4bc3e5f12856792913 and 6 for PR HEAD 0a5342a937f34ac558999ba60512c81f6f39e1cb in total