openshift / machine-api-provider-ibmcloud

Apache License 2.0
0 stars 12 forks source link

OCPBUGS-27872: add an extra vendor exclude to snyk config #36

Closed elmiko closed 6 months ago

elmiko commented 6 months ago

it seemed like the scan was failing on the vendor folder during the cachito expansion, this change adds an extra vendor option to the global excludes.

openshift-ci-robot commented 6 months ago

@elmiko: This pull request references Jira Issue OCPBUGS-27872, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/36): >it seemed like the scan was failing on the vendor folder during the cachito expansion, this change adds an extra vendor option to the global excludes. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-api-provider-ibmcloud). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 6 months ago

@elmiko: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud c1d485487e1415d5a5f5532edab1a829e5fb0c22 link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
racheljpg commented 6 months ago

/lgtm

JoelSpeed commented 6 months ago

/approve

openshift-ci[bot] commented 6 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-api-provider-ibmcloud/blob/main/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 6 months ago

@elmiko: Jira Issue OCPBUGS-27872: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-27872 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/36): >it seemed like the scan was failing on the vendor folder during the cachito expansion, this change adds an extra vendor option to the global excludes. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-api-provider-ibmcloud). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 6 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ibmcloud-machine-controllers-container-v4.16.0-202403011810.p0.g1a3a303.assembly.stream.el9 for distgit ose-ibmcloud-machine-controllers. All builds following this will include this PR.