search

openshift / machine-api-provider-ibmcloud

Apache License 2.0
0 stars 12 forks source link

Bug 2062579: IBMCloud: Verify machine profile #4

Closed cjschaef closed 2 years ago

cjschaef commented 2 years ago

Verify the machine's instance profile during creation to prevent the machine from being requeued to Provisioning when an invalid instance profile is provided.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=2062579

openshift-ci[bot] commented 2 years ago

@cjschaef: This pull request references Bugzilla bug 2062579, which is invalid:

Comment /bugzilla refresh to re-evaluate validity if changes to the Bugzilla bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/4): >Bug 2062579: IBMCloud: Verify machine profile Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
cjschaef commented 2 years ago

/bugzilla refresh

openshift-ci[bot] commented 2 years ago

@cjschaef: This pull request references Bugzilla bug 2062579, which is valid. The bug has been moved to the POST state. The bug has been updated to refer to the pull request using the external bug tracker.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target release (4.12.0) matches configured target release for branch (4.12.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, ON_DEV, POST, POST)

Requesting review from QA contact: /cc @huali9

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/4#issuecomment-1218478955): >/bugzilla refresh Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 years ago

@cjschaef: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud 09caf63c15282f7926478635c44b95249b32a24d link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
JoelSpeed commented 2 years ago

/approve

openshift-ci[bot] commented 2 years ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-api-provider-ibmcloud/blob/main/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 2 years ago

@cjschaef: All pull requests linked via external trackers have merged:

Bugzilla bug 2062579 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/4): >Bug 2062579: IBMCloud: Verify machine profile Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.