search

openshift / machine-api-provider-ibmcloud

Apache License 2.0
0 stars 12 forks source link

OCPBUGS-36185: IBMCloud: Handle pagination for subnets #41

Closed cjschaef closed 2 months ago

cjschaef commented 2 months ago

Add pagination support for subnet lookups.

Related: https://issues.redhat.com/browse/OCPBUGS-36185

openshift-ci-robot commented 2 months ago

@cjschaef: This pull request references Jira Issue OCPBUGS-36185, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sunzhaohua2

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/41): >Add pagination support for subnet lookups. > >Related: https://issues.redhat.com/browse/OCPBUGS-36185 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-api-provider-ibmcloud). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
JoelSpeed commented 2 months ago

/lgtm /approve /retest

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-api-provider-ibmcloud/blob/main/OWNERS)~~ [JoelSpeed] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@cjschaef: Jira Issue OCPBUGS-36185: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36185 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/41): >Add pagination support for subnet lookups. > >Related: https://issues.redhat.com/browse/OCPBUGS-36185 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-api-provider-ibmcloud). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-ibmcloud-machine-controllers-container-v4.17.0-202407041312.p0.gc2ea2b4.assembly.stream.el9 for distgit ose-ibmcloud-machine-controllers. All builds following this will include this PR.

cjschaef commented 2 months ago

/cherry-pick release-4.16 release-4.15 release-4.14 release-4.13 release-4.12

openshift-cherrypick-robot commented 2 months ago

@cjschaef: new pull request created: #42

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/41#issuecomment-2214720571): >/cherry-pick release-4.16 release-4.15 release-4.14 release-4.13 release-4.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.