openshift / machine-api-provider-ibmcloud

Apache License 2.0
0 stars 12 forks source link

[release-4.16] OCPBUGS-36698: IBMCloud: Handle pagination for subnets #42

Open openshift-cherrypick-robot opened 2 months ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #41

/assign cjschaef

/cherrypick release-4.15 release-4.14 release-4.13 release-4.12

openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: GitHub didn't allow me to assign the following users: cjschaef.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/42): >This is an automated cherry-pick of #41 > >/assign cjschaef > >/cherrypick release-4.15 release-4.14 release-4.13 release-4.12 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-36185 has been cloned as Jira Issue OCPBUGS-36698. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-36698: IBMCloud: Handle pagination for subnets

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/42): >This is an automated cherry-pick of #41 > >/assign cjschaef > >/cherrypick release-4.15 release-4.14 release-4.13 release-4.12 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-api-provider-ibmcloud). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-36698, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/pull/42): >This is an automated cherry-pick of #41 > >/assign cjschaef > >/cherrypick release-4.15 release-4.14 release-4.13 release-4.12 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-api-provider-ibmcloud). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Once this PR has been reviewed and has the lgtm label, please assign damdo for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/machine-api-provider-ibmcloud/blob/release-4.16/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cjschaef commented 1 month ago

/retest

cjschaef commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@openshift-cherrypick-robot: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-ibmcloud ef23f0f937861271fedfa956d2372e322e51fc62 link false /test e2e-ibmcloud

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cjschaef commented 1 month ago

Based on this comment in a CCCMO PR, the e2e-ibmcloud failure should be okay (one MonitorTest fixed the other required Infrastructure improvements). https://github.com/openshift/cluster-cloud-controller-manager-operator/pull/360#issuecomment-2229772048