search

openshift / machine-api-provider-ibmcloud

Apache License 2.0
0 stars 12 forks source link

Current ProviderSpec does not support creating an instance with multiple interfaces #8

Closed sunya-ch closed 1 year ago

sunya-ch commented 2 years ago

desired functionality I would like to use Machine API Operator to auto-scale an IBM Cloud instance with multiple network interface attachments and with allow-ip-spoofing attribute.

why the current version does not support this ProviderSpec does not contain attribute to refer to NetworkIntefaces attribute in vpcv1.instancePrototype when creating an instance.

https://github.com/openshift/machine-api-provider-ibmcloud/blob/91e9bba3dd059086eb6256214bcecbe2d7e25827/pkg/apis/ibmcloudprovider/v1/ibmcloudproviderconfig_types.go#L30-L78

solution

  1. add NetworkInterfaces []NetworkInterface to IBMCloudMachineProviderSpec struct.
  2. add AllowIfSpoofing bool to NetworkInterface struct
  3. parse NetworkInterfaces from IBMCloudMachineProviderSpec to vpcv1.InstancePrototype at InstanceCreate function.
  4. update machine.Status.Addresses of NetworkInterfaces at reconcileMachineWithCloudState function.
openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 1 year ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale

openshift-bot commented 1 year ago

Stale issues rot after 30d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle rotten. Rotten issues close after an additional 30d of inactivity. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle rotten /remove-lifecycle stale

openshift-bot commented 1 year ago

Rotten issues close after 30d of inactivity.

Reopen the issue by commenting /reopen. Mark the issue as fresh by commenting /remove-lifecycle rotten. Exclude this issue from closing again by commenting /lifecycle frozen.

/close

openshift-ci[bot] commented 1 year ago

@openshift-bot: Closing this issue.

In response to [this](https://github.com/openshift/machine-api-provider-ibmcloud/issues/8#issuecomment-1595496091): >Rotten issues close after 30d of inactivity. > >Reopen the issue by commenting `/reopen`. >Mark the issue as fresh by commenting `/remove-lifecycle rotten`. >Exclude this issue from closing again by commenting `/lifecycle frozen`. > >/close Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes/test-infra](https://github.com/kubernetes/test-infra/issues/new?title=Prow%20issue:) repository.