search

openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

OCPBUGS-29820: kubelet.service: wait for chronyd #4381

Closed haircommander closed 3 months ago

haircommander commented 3 months ago

to prevent races where the timesync happens after the kubelet starts, causing probe weirdness

- What I did

- How to verify it

- Description for the changelog

openshift-ci-robot commented 3 months ago

@haircommander: This pull request references Jira Issue OCPBUGS-29820, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4381): >to prevent races where the timesync happens after the kubelet starts, causing probe weirdness > > > >**- What I did** > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
haircommander commented 3 months ago

/retest

haircommander commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@haircommander: This pull request references Jira Issue OCPBUGS-29820, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/machine-config-operator/pull/4381#issuecomment-2135606523): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

@haircommander: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-images cef02763d6c2395c1ea55c8558469c5b348c11bc link false /test okd-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 3 months ago

/payload 4.16 nightly informing

openshift-ci[bot] commented 3 months ago

@rphillips: trigger 73 job(s) of type informing for the nightly release of OCP 4.16

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/2556ff80-1d37-11ef-8e42-fff5188f7f86-0

rphillips commented 3 months ago

/lgtm

haircommander commented 3 months ago

/retest

rphillips commented 3 months ago

/approve

rphillips commented 3 months ago

/assign @sinnykumari or @yuqi-zhang

openshift-ci[bot] commented 3 months ago

@rphillips: GitHub didn't allow me to assign the following users: or.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openshift/machine-config-operator/pull/4381#issuecomment-2147831156): >/assign @sinnykumari or @yuqi-zhang Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sinnykumari commented 3 months ago

/approve

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: haircommander, rphillips, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [sinnykumari] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

/retest-required

Remaining retests: 0 against base HEAD 743162d5531f580ac5d766ad882d16887bb268e9 and 2 for PR HEAD acf4a9d96e9cc295eaf7c122f65d246e467cfec8 in total

openshift-ci-robot commented 3 months ago

@haircommander: Jira Issue OCPBUGS-29820: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-29820 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4381): >to prevent races where the timesync happens after the kubelet starts, causing probe weirdness > > > >**- What I did** > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202406061914.p0.g83227d6.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.