search

openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

OCPBUGS-37840: [release-4.16] Introduce versioning for Auto Node Sizing feature #4382

Closed sairameshv closed 1 month ago

sairameshv commented 3 months ago
openshift-ci-robot commented 3 months ago

@sairameshv: This pull request references OCPNODE-2226 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.16.0" version, but no target version was set.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4382): >- What I did >Introducing versioning for the auto-node-sizing feature >- How to verify it >The presence of /etc/node-sizing-version.json file on a node indicates the introduction of versioning in the auto node sizing feature >- Description for the changelog >Auto node sizing feature gives recommendations about the kube reserved, system reserved memory and cpus as described in this [enhancement](https://github.com/openshift/enhancements/blob/master/enhancements/kubelet/kubelet-node-sizing.md) >These recommendations tend to change on a requirement basis i.e. based on the resource utilizations of system and kube, new features etc. >Hence, introduction of the versioning for this feature helps in modifying the memory, cpu values and also ease the upgrades without breaking the clusters. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

sairameshv commented 3 months ago

/assign @rphillips @harche

sairameshv commented 3 months ago

/retest

rphillips commented 3 months ago

/payload 4.16 ci blocking

openshift-ci[bot] commented 3 months ago

@rphillips: trigger 5 job(s) of type blocking for the ci release of OCP 4.16

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/97ca6200-2291-11ef-817f-ffc031543eb7-0

sairameshv commented 2 months ago

PR to introduce versioning in the master branch got merged - https://github.com/openshift/machine-config-operator/pull/4363 Hence, this PR is ready for the review.

sairameshv commented 2 months ago

/retest

rphillips commented 2 months ago

/lgtm

yuqi-zhang commented 2 months ago

2 quick questions:

  1. this seems to be a linked to a feature card. Is the expectation that we'd like this as a feature backport?
  2. the 4.16 PR only has "version 1" and thus is much lighter than the 4.17 PR, is that correct?
sairameshv commented 2 months ago

2 quick questions:

  1. this seems to be a linked to a feature card. Is the expectation that we'd like this as a feature backport?
  2. the 4.16 PR only has "version 1" and thus is much lighter than the 4.17 PR, is that correct?

Yes @yuqi-zhang ,

  1. We intend to backport this feature.
  2. Yes, we assume the older versions to be on version "1" so that the older calculations are still valid incase of upgrades to the newer versions. And the newer version clusters would be on version "2" reflecting the newer calculations.
sairameshv commented 2 months ago

/retest

rphillips commented 1 month ago

/lgtm /label backport-risk-assessed

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rphillips, sairameshv, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.16/OWNERS)~~ [yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sairameshv commented 1 month ago

/hold until the QE adds a cherry-pick-approved label

rphillips commented 1 month ago

/hold cancel

This won't merge without the cherry pick label.

rphillips commented 1 month ago

It looks like it needs a valid 4.16 bug attached as well.

sunilcio commented 1 month ago

/label cherry-pick-approved

openshift-ci-robot commented 1 month ago

@sairameshv: This pull request references OCPNODE-2463 which is a valid jira issue.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4382): >- What I did >Introducing versioning for the auto-node-sizing feature >- How to verify it >The presence of /etc/node-sizing-version.json file on a node indicates the introduction of versioning in the auto node sizing feature >- Description for the changelog >Auto node sizing feature gives recommendations about the kube reserved, system reserved memory and cpus as described in this [enhancement](https://github.com/openshift/enhancements/blob/master/enhancements/kubelet/kubelet-node-sizing.md) >These recommendations tend to change on a requirement basis i.e. based on the resource utilizations of system and kube, new features etc. >Hence, introduction of the versioning for this feature helps in modifying the memory, cpu values and also ease the upgrades without breaking the clusters. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sairameshv commented 1 month ago

/retest

openshift-ci[bot] commented 1 month ago

@sairameshv: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 4a67bded18b80c514a66ea89e8b7698c1c8e0c08 link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-vsphere-ovn-upi-zones 4a67bded18b80c514a66ea89e8b7698c1c8e0c08 link false /test e2e-vsphere-ovn-upi-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
rphillips commented 1 month ago

/retitle NO-JIRA: OCPNODE-2463: [release-4.16] Introduce versioning for Auto Node Sizing feature

openshift-ci-robot commented 1 month ago

@sairameshv: This pull request explicitly references no jira issue.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4382): >- What I did >Introducing versioning for the auto-node-sizing feature >- How to verify it >The presence of /etc/node-sizing-version.json file on a node indicates the introduction of versioning in the auto node sizing feature >- Description for the changelog >Auto node sizing feature gives recommendations about the kube reserved, system reserved memory and cpus as described in this [enhancement](https://github.com/openshift/enhancements/blob/master/enhancements/kubelet/kubelet-node-sizing.md) >These recommendations tend to change on a requirement basis i.e. based on the resource utilizations of system and kube, new features etc. >Hence, introduction of the versioning for this feature helps in modifying the memory, cpu values and also ease the upgrades without breaking the clusters. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rphillips commented 1 month ago

/retitle OCPNODE-2463: [release-4.16] Introduce versioning for Auto Node Sizing feature

openshift-ci-robot commented 1 month ago

@sairameshv: This pull request references OCPNODE-2463 which is a valid jira issue.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4382): >- What I did >Introducing versioning for the auto-node-sizing feature >- How to verify it >The presence of /etc/node-sizing-version.json file on a node indicates the introduction of versioning in the auto node sizing feature >- Description for the changelog >Auto node sizing feature gives recommendations about the kube reserved, system reserved memory and cpus as described in this [enhancement](https://github.com/openshift/enhancements/blob/master/enhancements/kubelet/kubelet-node-sizing.md) >These recommendations tend to change on a requirement basis i.e. based on the resource utilizations of system and kube, new features etc. >Hence, introduction of the versioning for this feature helps in modifying the memory, cpu values and also ease the upgrades without breaking the clusters. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rphillips commented 1 month ago

/retitle OCPBUGS-37840: [release-4.16] Introduce versioning for Auto Node Sizing feature

openshift-ci-robot commented 1 month ago

@sairameshv: This pull request references Jira Issue OCPBUGS-37840, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4382): >- What I did >Introducing versioning for the auto-node-sizing feature >- How to verify it >The presence of /etc/node-sizing-version.json file on a node indicates the introduction of versioning in the auto node sizing feature >- Description for the changelog >Auto node sizing feature gives recommendations about the kube reserved, system reserved memory and cpus as described in this [enhancement](https://github.com/openshift/enhancements/blob/master/enhancements/kubelet/kubelet-node-sizing.md) >These recommendations tend to change on a requirement basis i.e. based on the resource utilizations of system and kube, new features etc. >Hence, introduction of the versioning for this feature helps in modifying the memory, cpu values and also ease the upgrades without breaking the clusters. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
rphillips commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@rphillips: This pull request references Jira Issue OCPBUGS-37840, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.z) matches configured target version for branch (4.16.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-37839](https://issues.redhat.com//browse/OCPBUGS-37839) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-37839](https://issues.redhat.com//browse/OCPBUGS-37839) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4382#issuecomment-2263709465): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@sairameshv: Jira Issue OCPBUGS-37840: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-37840 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4382): >- What I did >Introducing versioning for the auto-node-sizing feature >- How to verify it >The presence of /etc/node-sizing-version.json file on a node indicates the introduction of versioning in the auto node sizing feature >- Description for the changelog >Auto node sizing feature gives recommendations about the kube reserved, system reserved memory and cpus as described in this [enhancement](https://github.com/openshift/enhancements/blob/master/enhancements/kubelet/kubelet-node-sizing.md) >These recommendations tend to change on a requirement basis i.e. based on the resource utilizations of system and kube, new features etc. >Hence, introduction of the versioning for this feature helps in modifying the memory, cpu values and also ease the upgrades without breaking the clusters. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

Distgit: ose-machine-config-operator This PR has been included in build ose-machine-config-operator-container-v4.16.0-202408012339.p0.gf57a679.assembly.stream.el9. All builds following this will include this PR.

openshift-merge-robot commented 1 month ago

Fix included in accepted release 4.16.0-0.nightly-2024-08-06-073514