search

openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

OCPBUGS-17658: Controller pod is spamming unknown field "spec.dns.spec.platform" message #4383

Closed dkhater-redhat closed 3 months ago

dkhater-redhat commented 3 months ago

- What I did Removed the platform field under spec in the CRD. Now it matches the 4.16 CRD.

- How to verify it oc logs <machine-controller-config-pod> | grep unknown

- Description for the changelog

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-17658, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4383): > > >**- What I did** >Removed the platform field under spec in the CRD. Now it matches the 4.16 CRD. > >**- How to verify it** >`oc logs | grep unknown ` > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sergiordlr commented 3 months ago

Hello! We can still see the log messages in the controller logs Using IPI on GCP

$ oc -n openshift-machine-config-operator logs $(oc -n openshift-machine-config-operator get pods -l k8s-app=machine-config-controller -o jsonpath='{.items[0].metadata.name}') -c machine-config-controller |grep platform
W0530 09:46:12.760882       1 warnings.go:70] unknown field "spec.dns.spec.platform"
W0530 09:46:12.785244       1 warnings.go:70] unknown field "spec.dns.spec.platform"
W0530 09:46:12.853634       1 warnings.go:70] unknown field "spec.dns.spec.platform"
W0530 09:46:13.890231       1 warnings.go:70] unknown field "spec.dns.spec.platform"
W0530 09:46:21.119815       1 warnings.go:70] unknown field "spec.dns.spec.platform"
W0530 09:46:21.273594       1 warnings.go:70] unknown field "spec.dns.spec.platform"
W0530 09:46:22.379775       1 warnings.go:70] unknown field "spec.dns.spec.platform"
dkhater-redhat commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-17658, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4383#issuecomment-2139941881): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-17658, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4383#issuecomment-2139957442): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-17658, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4383#issuecomment-2139992778): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-17658, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4383#issuecomment-2139999398): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-17658, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4383#issuecomment-2140006464): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-17658, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4383#issuecomment-2140013869): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-17658, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4383#issuecomment-2140029363): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

@dkhater-redhat: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-aws-ovn 585599f8e79af1a4d4fce1bd3279c3bf2d2c1b42 link false /test okd-scos-e2e-aws-ovn

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sergiordlr commented 3 months ago

Verified using IPI on AWS and IPI on GCP

No warning log lines were spammed

$ oc -n openshift-machine-config-operator logs $(oc -n openshift-machine-config-operator get pods -l k8s-app=machine-config-controller -o jsonpath='{.items[0].metadata.name}') -c machine-config-controller |grep platform

We add the qe label

/label qe-approved

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-17658, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4383): > > >**- What I did** >Removed the platform field under spec in the CRD. Now it matches the 4.16 CRD. > >**- How to verify it** >`oc logs | grep unknown ` > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-17658, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.14.z) matches configured target version for branch (4.14.z) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-34821](https://issues.redhat.com//browse/OCPBUGS-34821) is in the state Closed (Done), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-34821](https://issues.redhat.com//browse/OCPBUGS-34821) targets the "4.15.0" version, which is one of the valid target versions: 4.15.0, 4.15.z * bug has dependents

Requesting review from QA contact: /cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4383#issuecomment-2145893070): >/jira refresh > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
djoshy commented 3 months ago

/lgtm /label backport-risk-assessed

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: djoshy, dkhater-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.14/OWNERS)~~ [djoshy,dkhater-redhat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sergiordlr commented 3 months ago

/label cherry-pick-approved

openshift-ci-robot commented 3 months ago

@dkhater-redhat: Jira Issue OCPBUGS-17658: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-17658 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4383): > > >**- What I did** >Removed the platform field under spec in the CRD. Now it matches the 4.16 CRD. > >**- How to verify it** >`oc logs | grep unknown ` > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.14.0-202406041307.p0.ga50e9b0.assembly.stream.el8 for distgit ose-machine-config-operator. All builds following this will include this PR.