search

openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

OPNET-508: Remove ovsdb before applying nmstate configuration #4387

Open cybertron opened 3 months ago

cybertron commented 3 months ago

This is a gross hack to make migration from configure-ovs work. I doubt we actually want to do this, but I'm writing the patch to start a conversation about the proper way to do it.

- What I did

- How to verify it

- Description for the changelog

openshift-ci-robot commented 3 months ago

@cybertron: This pull request references OPNET-508 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4387): >This is a gross hack to make migration from configure-ovs work. I doubt we actually want to do this, but I'm writing the patch to start a conversation about the proper way to do it. > > > >**- What I did** > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[templates/common/baremetal/OWNERS](https://github.com/openshift/machine-config-operator/blob/master/templates/common/baremetal/OWNERS)~~ [cybertron] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 3 days ago

Issues go stale after 90d of inactivity.

Mark the issue as fresh by commenting /remove-lifecycle stale. Stale issues rot after an additional 30d of inactivity and eventually close. Exclude this issue from closing by commenting /lifecycle frozen.

If this issue is safe to close now please do so with /close.

/lifecycle stale