search

openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

OCPBUGS-34050: Default ipv4 NODE_IP to 0.0.0.0 #4388

Closed JoelSpeed closed 2 months ago

JoelSpeed commented 3 months ago

- What I did

This ensures that the --node-ip flag is defaulted to 0.0.0.0 on IPv4 clusters when otherwise not overridden by the kubelet-env file.

This we believe should Kubelet to start pods, that require the host IP to be set via the downwards API, prior to the kubelet accessing the kube API. This is helpful in hibernation recovery scenarios.

- How to verify it

- Description for the changelog

/hold for manual testing of the above theory

openshift-ci-robot commented 3 months ago

@JoelSpeed: This pull request references Jira Issue OCPBUGS-34050, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4388): >**- What I did** > >This ensures that the `--node-ip` flag is defaulted to `0.0.0.0` on IPv4 clusters when otherwise not overridden by the kubelet-env file. > >This we believe should Kubelet to start pods, that require the host IP to be set via the downwards API, prior to the kubelet accessing the kube API. This is helpful in hibernation recovery scenarios. > >**- How to verify it** > >**- Description for the changelog** > > >/hold for manual testing of the above theory Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
JoelSpeed commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@JoelSpeed: This pull request references Jira Issue OCPBUGS-34050, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sunzhaohua2

In response to [this](https://github.com/openshift/machine-config-operator/pull/4388#issuecomment-2149728805): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
JoelSpeed commented 3 months ago

/payload-job periodic-ci-openshift-release-master-nightly-4.17-e2e-metal-ipi-ovn-bm

openshift-ci[bot] commented 3 months ago

@JoelSpeed: trigger 1 job(s) for the /payload-(with-prs|job|aggregate|job-with-prs|aggregate-with-prs) command

See details on https://pr-payload-tests.ci.openshift.org/runs/ci/7a03b9e0-2338-11ef-95c3-726be7b50104-0

JoelSpeed commented 2 months ago

/test e2e-hypershift

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: JoelSpeed, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[templates/master/01-master-kubelet/OWNERS](https://github.com/openshift/machine-config-operator/blob/master/templates/master/01-master-kubelet/OWNERS)~~ [yuqi-zhang] - ~~[templates/worker/01-worker-kubelet/OWNERS](https://github.com/openshift/machine-config-operator/blob/master/templates/worker/01-worker-kubelet/OWNERS)~~ [yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
JoelSpeed commented 2 months ago

/hold cancel /retest-required

JoelSpeed commented 2 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 2 months ago

@JoelSpeed: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4388#issuecomment-2168047052): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
csrwng commented 2 months ago

The hypershift failure is likely due to slowness in the cloud infra. It does not look like this PR is negatively affecting hypershift. It should be ok to override.

Mutate over budget on nodepool tests:

pod control-plane-operator-75fb8fd9d-5rclw over budget: budget: 4200, actual: 4484
sdodson commented 2 months ago

/override ci/prow/e2e-hypershift

openshift-ci[bot] commented 2 months ago

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-hypershift

In response to [this](https://github.com/openshift/machine-config-operator/pull/4388#issuecomment-2168120060): >/override ci/prow/e2e-hypershift Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 2 months ago

@JoelSpeed: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 65be00a1d8e68a68e97373b71af6badf954c3223 link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@JoelSpeed: Jira Issue OCPBUGS-34050: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-34050 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4388): >**- What I did** > >This ensures that the `--node-ip` flag is defaulted to `0.0.0.0` on IPv4 clusters when otherwise not overridden by the kubelet-env file. > >This we believe should Kubelet to start pods, that require the host IP to be set via the downwards API, prior to the kubelet accessing the kube API. This is helpful in hibernation recovery scenarios. > >**- How to verify it** > >**- Description for the changelog** > > >/hold for manual testing of the above theory Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 2 months ago

@JoelSpeed: new pull request created: #4409

In response to [this](https://github.com/openshift/machine-config-operator/pull/4388#issuecomment-2168047052): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202406141612.p0.g58d31f0.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.

EmilienM commented 3 weeks ago

@JoelSpeed FYI https://issues.redhat.com/browse/OCPBUGS-38553 We are investigating an issue and this PR might the root cause (not 100% sure).