openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

[DNM] [WIP]: Auto tune enable default #4389

Closed sairameshv closed 2 months ago

sairameshv commented 3 months ago

PR to enable the auto-node-sizing feature by default to test for any issues.

cc: @harche @rphillips

openshift-ci[bot] commented 3 months ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: sairameshv Once this PR has been reviewed and has the lgtm label, please assign sinnykumari for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files: - **[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)** Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
harche commented 3 months ago

/payload 4.16 ci blocking

sairameshv commented 3 months ago

Cluster installation passed locally with some delay and hence opening to Ready state to see the outputs of the e2e jobs

openshift-ci[bot] commented 2 months ago

@sairameshv: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sairameshv commented 2 months ago

@rphillips , @harche I verified the cluster installation for this PR and also observed that the auto-node-sizing feature is enabled on all the nodes.

$ oc debug node/ci-ln-cbt9tsb-72292-bj6fr-master-0
Starting pod/ci-ln-cbt9tsb-72292-bj6fr-master-0-debug-fmw8t ...
To use host binaries, run `chroot /host`

Pod IP: 10.0.0.4
If you don't see a command prompt, try pressing enter.
sh-5.1# chroot /host

sh-5.1# cat /etc/node-sizing*
NODE_SIZING_ENABLED=true
SYSTEM_RESERVED_MEMORY=1Gi
SYSTEM_RESERVED_CPU=500m
SYSTEM_RESERVED_ES=1Gi
{"version": 2}
SYSTEM_RESERVED_MEMORY=3Gi
SYSTEM_RESERVED_CPU=0.12
SYSTEM_RESERVED_ES=1Gi
sairameshv commented 2 months ago

Original PR that introduces versioning to the auto node sizing feature is here.

sairameshv commented 2 months ago

Closing this as the original PR has been merged !!