search

openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

[release-4.15] OCPBUGS-35220: Check both ready and health ingress endpoints #4398

Closed openshift-cherrypick-robot closed 1 month ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #4356

/assign cybertron

openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33357 has been cloned as Jira Issue OCPBUGS-35220. Will retitle bug to link to clone. /retitle [release-4.15] OCPBUGS-35220: Check both ready and health ingress endpoints

In response to [this](https://github.com/openshift/machine-config-operator/pull/4398): >This is an automated cherry-pick of #4356 > >/assign cybertron Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35220, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4398): >This is an automated cherry-pick of #4356 > >/assign cybertron Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/okd-scos-e2e-gcp-ovn-upgrade 11e8f78dab75fcc906de66df5021603233c9f883 link false /test okd-scos-e2e-gcp-ovn-upgrade
ci/prow/e2e-vsphere-ovn-upi-zones 11e8f78dab75fcc906de66df5021603233c9f883 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/okd-scos-e2e-aws-ovn 11e8f78dab75fcc906de66df5021603233c9f883 link false /test okd-scos-e2e-aws-ovn
ci/prow/okd-scos-e2e-gcp-op 11e8f78dab75fcc906de66df5021603233c9f883 link false /test okd-scos-e2e-gcp-op
ci/prow/okd-scos-e2e-vsphere-ovn 11e8f78dab75fcc906de66df5021603233c9f883 link false /test okd-scos-e2e-vsphere-ovn
ci/prow/e2e-gcp-op-layering 11e8f78dab75fcc906de66df5021603233c9f883 link false /test e2e-gcp-op-layering

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cybertron commented 2 months ago

/lgtm /label backport-risk-assessed

cybertron commented 2 months ago

/retest-required

cybertron commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@cybertron: This pull request references Jira Issue OCPBUGS-35220, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4398#issuecomment-2192427277): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cybertron commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@cybertron: This pull request references Jira Issue OCPBUGS-35220, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-33357](https://issues.redhat.com//browse/OCPBUGS-33357) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-33357](https://issues.redhat.com//browse/OCPBUGS-33357) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/machine-config-operator/pull/4398#issuecomment-2194968671): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
zhaozhanqi commented 1 month ago

/label cherry-pick-approved

zhaozhanqi commented 1 month ago

/label qe-approved

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35220, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.15.z) matches configured target version for branch (4.15.z) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-33357](https://issues.redhat.com//browse/OCPBUGS-33357) is in the state Closed (Done-Errata), which is one of the valid states (VERIFIED, RELEASE PENDING, CLOSED (ERRATA), CLOSED (CURRENT RELEASE), CLOSED (DONE), CLOSED (DONE-ERRATA)) * dependent [Jira Issue OCPBUGS-33357](https://issues.redhat.com//browse/OCPBUGS-33357) targets the "4.16.0" version, which is one of the valid target versions: 4.16.0, 4.16.z * bug has dependents

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/machine-config-operator/pull/4398): >This is an automated cherry-pick of #4356 > >/assign cybertron Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.15/OWNERS)~~ [yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD a707d4226a80f1606487571d6b8cd96e713cba08 and 2 for PR HEAD 11e8f78dab75fcc906de66df5021603233c9f883 in total

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35220: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35220 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4398): >This is an automated cherry-pick of #4356 > >/assign cybertron Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.15.0-202407130107.p0.gcee5dd7.assembly.stream.el8 for distgit ose-machine-config-operator. All builds following this will include this PR.

openshift-merge-robot commented 1 month ago

Fix included in accepted release 4.15.0-0.nightly-2024-07-13-071125

cybertron commented 1 month ago

/cherry-pick release-4.14

openshift-cherrypick-robot commented 1 month ago

@cybertron: #4398 failed to apply on top of branch "release-4.14":

Applying: OCPBUGS-33357: Check both ready and health ingress endpoints
Using index info to reconstruct a base tree...
M   templates/master/00-master/on-prem/files/keepalived-keepalived.yaml
M   templates/worker/00-worker/on-prem/files/keepalived-keepalived.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/worker/00-worker/on-prem/files/keepalived-keepalived.yaml
CONFLICT (content): Merge conflict in templates/worker/00-worker/on-prem/files/keepalived-keepalived.yaml
Auto-merging templates/master/00-master/on-prem/files/keepalived-keepalived.yaml
CONFLICT (content): Merge conflict in templates/master/00-master/on-prem/files/keepalived-keepalived.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 OCPBUGS-33357: Check both ready and health ingress endpoints
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/machine-config-operator/pull/4398#issuecomment-2231292939): >/cherry-pick release-4.14 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.