search

openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

MCO-1147, OCPBUGS-34225: Pick up openshift/kubernetes 1.30 rebase updates, Dockerfile Update #4399

Closed dkhater-redhat closed 2 months ago

dkhater-redhat commented 2 months ago

- What I did openshift/kube dep bump to 1.30

Updated the go.mod, go.sum and vendor dependencies pointing to the kube1.30 libraries. This includes all direct kubernetes related libraries as well as openshift/api , openshift/client-go, openshift/library-go and openshift/runtime-utils

- How to verify it

- Description for the changelog

dkhater-redhat commented 2 months ago

/retest

openshift-ci-robot commented 2 months ago

@dkhater-redhat: This pull request references MCO-1108 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4399): > > >**- What I did** >openshift/kube dep bump to 1.30 > >Updated the go.mod, go.sum and vendor dependencies pointing to the kube1.30 libraries. This includes all direct kubernetes related libraries as well as openshift/api , openshift/client-go, openshift/library-go and openshift/runtime-utils > > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 2 months ago

/test verify

dkhater-redhat commented 2 months ago

/test verify

dkhater-redhat commented 2 months ago

/test verify

dkhater-redhat commented 2 months ago

/test verify

dkhater-redhat commented 2 months ago

/test verify

dkhater-redhat commented 2 months ago

/test verify

dkhater-redhat commented 2 months ago

/test verify

dkhater-redhat commented 2 months ago

/test verify

dkhater-redhat commented 2 months ago

/test verify

dkhater-redhat commented 2 months ago

/test verify

sinnykumari commented 2 months ago

Is commit https://github.com/openshift/machine-config-operator/pull/4399/commits/eccf2545ea9a22b6faa05a81867465298d7855a6 related to kube bump update or can go as separate PR?

dkhater-redhat commented 2 months ago

/retest-required

openshift-ci[bot] commented 2 months ago

@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upi-zones 24183b4bc06cda6c81f60beccfc047e1f239e6ef link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-azure-ovn-upgrade-out-of-change 24183b4bc06cda6c81f60beccfc047e1f239e6ef link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@dkhater-redhat: This pull request references MCO-1147 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4399): > > >**- What I did** >openshift/kube dep bump to 1.30 > >Updated the go.mod, go.sum and vendor dependencies pointing to the kube1.30 libraries. This includes all direct kubernetes related libraries as well as openshift/api , openshift/client-go, openshift/library-go and openshift/runtime-utils > > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sinnykumari commented 2 months ago

/lgtm Putting hold for QE approval /hold

openshift-ci-robot commented 2 months ago

@dkhater-redhat: This pull request references MCO-1147 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references Jira Issue OCPBUGS-34225, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4399): > > >**- What I did** >openshift/kube dep bump to 1.30 > >Updated the go.mod, go.sum and vendor dependencies pointing to the kube1.30 libraries. This includes all direct kubernetes related libraries as well as openshift/api , openshift/client-go, openshift/library-go and openshift/runtime-utils > > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [dkhater-redhat,sinnykumari] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
ptalgulk01 commented 2 months ago

All MCO test cases have passed in a IPI on AWS cluster. Adding the qe-approved label

/label qe-approved

openshift-ci-robot commented 2 months ago

@dkhater-redhat: This pull request references MCO-1147 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

This pull request references Jira Issue OCPBUGS-34225, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sergiordlr

In response to [this](https://github.com/openshift/machine-config-operator/pull/4399): > > >**- What I did** >openshift/kube dep bump to 1.30 > >Updated the go.mod, go.sum and vendor dependencies pointing to the kube1.30 libraries. This includes all direct kubernetes related libraries as well as openshift/api , openshift/client-go, openshift/library-go and openshift/runtime-utils > > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sergiordlr commented 2 months ago

Since it has been pre-merge verified, we can unhold this PR /unhold

openshift-ci-robot commented 2 months ago

@dkhater-redhat: Jira Issue OCPBUGS-34225: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-34225 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4399): > > >**- What I did** >openshift/kube dep bump to 1.30 > >Updated the go.mod, go.sum and vendor dependencies pointing to the kube1.30 libraries. This includes all direct kubernetes related libraries as well as openshift/api , openshift/client-go, openshift/library-go and openshift/runtime-utils > > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sinnykumari commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@sinnykumari: Jira Issue OCPBUGS-34225: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-34225 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4399#issuecomment-2200842235): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202407020721.p0.gd37b0a6.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.