openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

OCPBUGS-34225: Updates to 4.17 Dockerfile Image #4400

Closed dkhater-redhat closed 2 months ago

dkhater-redhat commented 2 months ago

- What I did updates dockerfile to 4.17

- How to verify it

- Description for the changelog

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dkhater-redhat

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [dkhater-redhat] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

@dkhater-redhat: This pull request references MCO-1108 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4400): > > >**- What I did** >updates dockerfile to 4.17 > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-34225, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4400): > > >**- What I did** >updates dockerfile to 4.17 > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
dkhater-redhat commented 2 months ago

/retest-required

openshift-ci[bot] commented 2 months ago

@dkhater-redhat: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-hypershift 40eb031f7ec383484b91e075c9ae3f4ba7b3e812 link true /test e2e-hypershift
ci/prow/e2e-gcp-op-techpreview 40eb031f7ec383484b91e075c9ae3f4ba7b3e812 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-vsphere-ovn-upi-zones 40eb031f7ec383484b91e075c9ae3f4ba7b3e812 link false /test e2e-vsphere-ovn-upi-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sinnykumari commented 2 months ago

ART bot PR https://github.com/openshift/machine-config-operator/pull/4380/files#diff-33ef32bf6c23acb95f5902d7097b7a1d5128ca061167ec0716715b0b9eeaa5f6R3 also bumps go.mod to use go 1.22 . We will probably need to do that as well as part of this bump to actually switch MCO building from go 1.22 . With PR as it is merged, I think ART bot will most likely still complain and open a new PR and bug to get changes into go,mod.

Also, I see that kube bump PR https://github.com/openshift/machine-config-operator/pull/4399 already doing the go mod update as well to go 1.22 . So, we can also incorporate this fix in same PR or keep it as it is.

dkhater-redhat commented 2 months ago

I opened this PR to make sure CI would pass with the above edits. I can close this one and continue working on the other PR!

openshift-ci-robot commented 2 months ago

@dkhater-redhat: This pull request references Jira Issue OCPBUGS-34225. The bug has been updated to no longer refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4400): > > >**- What I did** >updates dockerfile to 4.17 > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.