search

openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

OCPNODE-2336: Drop ClusterImagePolicy validation on scope conflicts with release-image repo #4401

Closed QiWang19 closed 2 months ago

QiWang19 commented 2 months ago

…ith release-image repo

Remove the restriction on setting policy for release payload repository to not block the implementation for https://github.com/openshift/enhancements/pull/1633

- What I did

- How to verify it

- Description for the changelog

openshift-ci-robot commented 2 months ago

@QiWang19: This pull request references OCPNODE-2336 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.17.0" version, but no target version was set.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4401): >…ith release-image repo > >Remove the restriction on setting policy for release payload repository to not block the implementation for https://github.com/openshift/enhancements/pull/1633 > > > >**- What I did** > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 2 months ago

@QiWang19: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 829684eb4e55267572a59a0407b5b4a5348b599e link false /test e2e-azure-ovn-upgrade-out-of-change
ci/prow/e2e-vsphere-ovn-zones 829684eb4e55267572a59a0407b5b4a5348b599e link false /test e2e-vsphere-ovn-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
QiWang19 commented 2 months ago

@mtrmac PTAL

QiWang19 commented 2 months ago

/assign @djoshy

openshift-ci[bot] commented 2 months ago

@QiWang19: GitHub didn't allow me to assign the following users: assign.

Note that only openshift members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. For more information please see the contributor guide

In response to [this](https://github.com/openshift/machine-config-operator/pull/4401#issuecomment-2160830313): >/assign @assign Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
QiWang19 commented 2 months ago

/assign @yuqi-zhang

wking commented 2 months ago

Avoid eliding the pull title, because this gets included in release-controller diffs and such:

/retitle OCPNODE-2336: Drop ClusterImagePolicy validation on scope conflicts with release-image repo

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: QiWang19, saschagrunert, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202406120610.p0.geafd0ba.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.