search

openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

[release-4.16] OCPBUGS-35299: Panic when we remove an OCB infra MCP and we try to create new ones with different names #4403

Closed openshift-cherrypick-robot closed 2 months ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #4396

/assign inesqyx

openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33129 has been cloned as Jira Issue OCPBUGS-35299. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-35299: Panic when we remove an OCB infra MCP and we try to create new ones with different names

In response to [this](https://github.com/openshift/machine-config-operator/pull/4403): >This is an automated cherry-pick of #4396 > >/assign inesqyx Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35299, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4403): >This is an automated cherry-pick of #4396 > >/assign inesqyx Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
inesqyx commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@inesqyx: This pull request references Jira Issue OCPBUGS-35299, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4403#issuecomment-2161392571): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
inesqyx commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@inesqyx: This pull request references Jira Issue OCPBUGS-35299, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-33129](https://issues.redhat.com//browse/OCPBUGS-33129) is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-33129](https://issues.redhat.com//browse/OCPBUGS-33129) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @sergiordlr

In response to [this](https://github.com/openshift/machine-config-operator/pull/4403#issuecomment-2161401813): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
inesqyx commented 2 months ago

/retest-required

sergiordlr commented 2 months ago

Verified using IPI on AWS

  1. Create a custom infra MCP
  2. Create a MOSC resource for the infra pool
  3. Wait for the builder pod to be running
  4. Remove the MOSC resource

There is no panic in the controller pod and there is no panic in the machine-os-builder pod.

We can see this message in the machine-os-builder pod instead of the panic error:

I0612 09:58:48.211378 1 pod_build_controller.go:302] Dropping pod "openshift-machine-config-operator/build-rendered-infra-e452ee25bfdc7dde6a056e939fac0557" out of the queue: unable to update with build pod status: Missing MOSC/MOSB for pool infra

/label qe-approved /label cherry-pick-approved

openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35299, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note text is set and does not match the template * dependent bug [Jira Issue OCPBUGS-33129](https://issues.redhat.com//browse/OCPBUGS-33129) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-33129](https://issues.redhat.com//browse/OCPBUGS-33129) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @sergiordlr

In response to [this](https://github.com/openshift/machine-config-operator/pull/4403): >This is an automated cherry-pick of #4396 > >/assign inesqyx Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sergiordlr commented 2 months ago

/retest

sinnykumari commented 2 months ago

/lgtm /approve /label backport-risk-assessed

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.16/OWNERS)~~ [sinnykumari] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 03b4015daebb7b41004cd581bb9cbe7faacf120a and 2 for PR HEAD a6277f31d50e8f86053eddceb85db99ae6b19982 in total

inesqyx commented 2 months ago

/retest-required

openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview a6277f31d50e8f86053eddceb85db99ae6b19982 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-vsphere-ovn-upi-zones a6277f31d50e8f86053eddceb85db99ae6b19982 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-azure-ovn-upgrade-out-of-change a6277f31d50e8f86053eddceb85db99ae6b19982 link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35299: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35299 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4403): >This is an automated cherry-pick of #4396 > >/assign inesqyx Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202406121536.p0.gb118fb4.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.

openshift-merge-robot commented 2 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-06-13-031814