openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

OCPBUGS-35300: Azure: add Azure specific dnsmasq ordering #4404

Closed yuqi-zhang closed 2 months ago

yuqi-zhang commented 2 months ago

In 4.14 we slightly tweaked the services such that mcd-pull no longer depends on network-online.target. This broke some ARO disconnected environments that needed dnsmasq to be ready before the MCD-pull runs on firstboot.

Add in a new Azure template for MCD-pull with an additional After=dnsmasq.service so the strict ordering of:

  1. ovs-configuration
  2. dnsmasq
  3. mcd-pull
  4. mcd-firstboot

is adhered to.

- What I did

- How to verify it

- Description for the changelog

openshift-ci-robot commented 2 months ago

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-35300, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4404): >In 4.14 we slightly tweaked the services such that mcd-pull no longer depends on network-online.target. This broke some ARO disconnected environments that needed dnsmasq to be ready before the MCD-pull runs on firstboot. > >Add in a new Azure template for MCD-pull with an additional After=dnsmasq.service so the strict ordering of: > >1. ovs-configuration >2. dnsmasq >3. mcd-pull >4. mcd-firstboot > >is adhered to. > > > >**- What I did** > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yuqi-zhang commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-35300, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sergiordlr

In response to [this](https://github.com/openshift/machine-config-operator/pull/4404#issuecomment-2161847737): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sinnykumari commented 2 months ago

/lgtm

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sinnykumari, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [sinnykumari,yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 2 months ago

/retest-required

Remaining retests: 0 against base HEAD 0278c483093b751902be798d9c9fc9de8d976850 and 2 for PR HEAD a5dcc6fe225562079f1b3ab6667d3d2efc6c8436 in total

openshift-ci[bot] commented 2 months ago

@yuqi-zhang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-gcp-op-techpreview a5dcc6fe225562079f1b3ab6667d3d2efc6c8436 link false /test e2e-gcp-op-techpreview

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@yuqi-zhang: Jira Issue OCPBUGS-35300: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35300 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4404): >In 4.14 we slightly tweaked the services such that mcd-pull no longer depends on network-online.target. This broke some ARO disconnected environments that needed dnsmasq to be ready before the MCD-pull runs on firstboot. > >Add in a new Azure template for MCD-pull with an additional After=dnsmasq.service so the strict ordering of: > >1. ovs-configuration >2. dnsmasq >3. mcd-pull >4. mcd-firstboot > >is adhered to. > > > >**- What I did** > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yuqi-zhang commented 2 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 2 months ago

@yuqi-zhang: new pull request created: #4406

In response to [this](https://github.com/openshift/machine-config-operator/pull/4404#issuecomment-2163349429): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202406121741.p0.gfc878b8.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.

wking commented 2 months ago

4411 is up suggesting we revert this change.