search

openshift / machine-config-operator

Apache License 2.0
245 stars 401 forks source link

[release-4.16] OCPBUGS-35291: Default ipv4 NODE_IP to 0.0.0.0 #4409

Closed openshift-cherrypick-robot closed 2 months ago

openshift-cherrypick-robot commented 2 months ago

This is an automated cherry-pick of #4388

/assign JoelSpeed

openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Detected clone of Jira Issue OCPBUGS-34050 with correct target version. Will retitle the PR to link to the clone. /retitle [release-4.16] OCPBUGS-35291: Default ipv4 NODE_IP to 0.0.0.0

In response to [this](https://github.com/openshift/machine-config-operator/pull/4409): >This is an automated cherry-pick of #4388 > >/assign JoelSpeed Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35291, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4409): >This is an automated cherry-pick of #4388 > >/assign JoelSpeed Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sinnykumari commented 2 months ago

Clean backport /lgtm /approve /label backport-risk-assessed

openshift-ci[bot] commented 2 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, sinnykumari

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[templates/master/01-master-kubelet/OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.16/templates/master/01-master-kubelet/OWNERS)~~ [sinnykumari] - ~~[templates/worker/01-worker-kubelet/OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.16/templates/worker/01-worker-kubelet/OWNERS)~~ [sinnykumari] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sergiordlr commented 2 months ago

/label cherry-pick-approved

sdodson commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@sdodson: This pull request references Jira Issue OCPBUGS-35291, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4409#issuecomment-2168639114): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sdodson commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@sdodson: This pull request references Jira Issue OCPBUGS-35291, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4409#issuecomment-2168640807): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sdodson commented 2 months ago

/jira refresh

openshift-ci-robot commented 2 months ago

@sdodson: This pull request references Jira Issue OCPBUGS-35291, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-34050](https://issues.redhat.com//browse/OCPBUGS-34050) is in the state MODIFIED, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-34050](https://issues.redhat.com//browse/OCPBUGS-34050) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @sunzhaohua2

In response to [this](https://github.com/openshift/machine-config-operator/pull/4409#issuecomment-2168641920): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sdodson commented 2 months ago

/retest-required

openshift-ci[bot] commented 2 months ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upi-zones 95bfa4556408415000cb272243c5ac764113304e link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-vsphere-ovn-zones 95bfa4556408415000cb272243c5ac764113304e link false /test e2e-vsphere-ovn-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 2 months ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35291: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-35291 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4409): >This is an automated cherry-pick of #4388 > >/assign JoelSpeed Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202406150005.p0.ge03a9a4.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.

openshift-merge-robot commented 2 months ago

Fix included in accepted release 4.16.0-0.nightly-2024-06-18-054744