openshift / machine-config-operator

Apache License 2.0
244 stars 396 forks source link

OCPBUGS-35519: Revert "Azure: add Azure specific dnsmasq ordering" #4411

Closed yuqi-zhang closed 1 month ago

yuqi-zhang commented 1 month ago

This reverts commit a5dcc6fe225562079f1b3ab6667d3d2efc6c8436.

In an attempt to fix https://issues.redhat.com/browse/OCPBUGS-35300, we introduced an Azure-specific dependency on dnsmasq, which introduced a dependency loop. This bug aims to revert that chain, which so far only made it to 4.17 and 4.16.

openshift-ci-robot commented 1 month ago

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-35519, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4411): >This reverts commit a5dcc6fe225562079f1b3ab6667d3d2efc6c8436. > >In an attempt to fix https://issues.redhat.com/browse/OCPBUGS-35300, we introduced an Azure-specific dependency on dnsmasq, which introduced a dependency loop. This bug aims to revert that chain, which so far only made it to 4.17 and 4.16. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sinnykumari commented 1 month ago

Ouch, wasn't obvious from the PR. I wish systemd was more smarter to break the loop :smile: /lgtm

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sinnykumari, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [sinnykumari,yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD 58d31f062a03680185f1c44f63decb77c7f1fabc and 2 for PR HEAD 719d21b3eaea487aebad525ef0ba48fb21d5fb71 in total

sinnykumari commented 1 month ago

/test e2e-hypershift

openshift-ci-robot commented 1 month ago

/retest-required

Remaining retests: 0 against base HEAD e505c7bf1e28551ad01cbf0b0913bb3580492c6f and 1 for PR HEAD 719d21b3eaea487aebad525ef0ba48fb21d5fb71 in total

wking commented 1 month ago

/retest-required

sinnykumari commented 1 month ago

e2e-hypeshift is broken for a while which is unrelated to the PR. This PR is anyway reverting back the recent changes we did. /override ci/prow/e2e-hypershift

openshift-ci[bot] commented 1 month ago

@sinnykumari: Overrode contexts on behalf of sinnykumari: ci/prow/e2e-hypershift

In response to [this](https://github.com/openshift/machine-config-operator/pull/4411#issuecomment-2176447298): >e2e-hypeshift is broken for a while which is unrelated to the PR. This PR is anyway reverting back the recent changes we did. >/override ci/prow/e2e-hypershift Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 1 month ago

@yuqi-zhang: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-azure-ovn-upgrade-out-of-change 719d21b3eaea487aebad525ef0ba48fb21d5fb71 link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sinnykumari commented 1 month ago

/test e2e-gcp-op-single-node

openshift-ci-robot commented 1 month ago

@yuqi-zhang: Jira Issue OCPBUGS-35519: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35519 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4411): >This reverts commit a5dcc6fe225562079f1b3ab6667d3d2efc6c8436. > >In an attempt to fix https://issues.redhat.com/browse/OCPBUGS-35300, we introduced an Azure-specific dependency on dnsmasq, which introduced a dependency loop. This bug aims to revert that chain, which so far only made it to 4.17 and 4.16. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
yuqi-zhang commented 1 month ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 1 month ago

@yuqi-zhang: new pull request created: #4414

In response to [this](https://github.com/openshift/machine-config-operator/pull/4411#issuecomment-2177314143): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 1 month ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202406190043.p0.g1933aac.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.