openshift / machine-config-operator

Apache License 2.0
244 stars 396 forks source link

[release-4.16] OCPBUGS-35753: Fix reference to $host_file #4413

Closed openshift-cherrypick-robot closed 3 weeks ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #4353

/assign cybertron

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-33331 has been cloned as Jira Issue OCPBUGS-35753. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-35753: Fix reference to $host_file

In response to [this](https://github.com/openshift/machine-config-operator/pull/4413): >This is an automated cherry-pick of #4353 > >/assign cybertron Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35753, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4413): >This is an automated cherry-pick of #4353 > >/assign cybertron Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cybertron commented 1 month ago

/lgtm /label backport-risk-assessed

openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cybertron, openshift-cherrypick-robot

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[templates/common/baremetal/OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.16/templates/common/baremetal/OWNERS)~~ [cybertron] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-zones 8c132332a94467bace276247540d5e2d83045852 link false /test e2e-vsphere-ovn-zones
ci/prow/e2e-gcp-op-techpreview 8c132332a94467bace276247540d5e2d83045852 link false /test e2e-gcp-op-techpreview
ci/prow/e2e-vsphere-ovn-upi-zones 8c132332a94467bace276247540d5e2d83045852 link false /test e2e-vsphere-ovn-upi-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
cybertron commented 1 month ago

/jira refresh

openshift-ci-robot commented 1 month ago

@cybertron: This pull request references Jira Issue OCPBUGS-35753, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4413#issuecomment-2176950397): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cybertron commented 1 month ago

/jira refresh

This time I modified the correct bug. I think.

openshift-ci-robot commented 1 month ago

@cybertron: This pull request references Jira Issue OCPBUGS-35753, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-33331](https://issues.redhat.com//browse/OCPBUGS-33331) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-33331](https://issues.redhat.com//browse/OCPBUGS-33331) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @zhaozhanqi

In response to [this](https://github.com/openshift/machine-config-operator/pull/4413#issuecomment-2176952870): >/jira refresh > >This time I modified the correct bug. I think. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
qiowang721 commented 1 month ago

/label cherry-pick-approved

openshift-ci[bot] commented 1 month ago

@qiowang721: Can not set label cherry-pick-approved: Must be member in one of these teams: []

In response to [this](https://github.com/openshift/machine-config-operator/pull/4413#issuecomment-2177339545): >/label cherry-pick-approved Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
qiowang721 commented 1 month ago

@zhaozhanqi could you help to add label cherry-pick-approved? Thanks so much!

qiowang721 commented 1 month ago

/retest-required

zhaozhanqi commented 1 month ago

/label cherry-pick-approved

qiowang721 commented 1 month ago

/label qe-approved

pre-merge test with cluster-bot passed. Install cluster with host-specified machine-config for br-ex bridge configuration, passed.

# oc debug node/master-0
Starting pod/master-0-debug-vfxc5 ...
To use host binaries, run `chroot /host`
Pod IP: 192.168.111.20
If you don't see a command prompt, try pressing enter.
sh-5.1# chroot /host
sh-5.1# journalctl -u nmstate-configuration 
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + systemctl -q is-enabled mtu-migration
Jun 19 01:59:44 master-0 systemd[1]: Starting Applies per-node NMState network configuration...
Jun 19 01:59:44 master-0 systemctl[1631]: Failed to get unit file state for mtu-migration.service: No such file or directory
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + echo 'Cleaning up left over mtu migration configuration'
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: Cleaning up left over mtu migration configuration
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + rm -rf /etc/cno/mtu-migration
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + '[' -e /etc/nmstate/openshift/applied ']'
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + src_path=/etc/nmstate/openshift
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + dst_path=/etc/nmstate
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1633]: ++ hostname -s
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + hostname=master-0
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + host_file=master-0.yml
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + cluster_file=cluster.yml
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + config_file=
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + '[' -s /etc/nmstate/openshift/master-0.yml ']'
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + config_file=master-0.yml
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + '[' -e /etc/nmstate/master-0.yml ']'
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + cp /etc/nmstate/openshift/master-0.yml /etc/nmstate
Jun 19 01:59:44 master-0 nmstate-configuration.sh[1630]: + touch /etc/nmstate/openshift/applied
Jun 19 01:59:44 master-0 systemd[1]: nmstate-configuration.service: Deactivated successfully.
Jun 19 01:59:44 master-0 systemd[1]: Finished Applies per-node NMState network configuration.
sh-5.1# 
sh-5.1# ls /etc/nmstate/
README  master-0.applied  master-0.yml  nmstate.conf  openshift
sh-5.1# ls /etc/nmstate/openshift
applied  master-0.yml  master-1.yml  master-2.yml
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35753, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-33331](https://issues.redhat.com//browse/OCPBUGS-33331) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-33331](https://issues.redhat.com//browse/OCPBUGS-33331) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @qiowang721

In response to [this](https://github.com/openshift/machine-config-operator/pull/4413): >This is an automated cherry-pick of #4353 > >/assign cybertron Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35753: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35753 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4413): >This is an automated cherry-pick of #4353 > >/assign cybertron Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202406280629.p0.gbb771f7.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.

openshift-merge-robot commented 2 weeks ago

Fix included in accepted release 4.16.0-0.nightly-2024-07-01-133841