search

openshift / machine-config-operator

Apache License 2.0
244 stars 396 forks source link

[release-4.16] OCPBUGS-35806: Revert "Azure: add Azure specific dnsmasq ordering" #4414

Closed openshift-cherrypick-robot closed 3 weeks ago

openshift-cherrypick-robot commented 1 month ago

This is an automated cherry-pick of #4411

/assign yuqi-zhang

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35519 has been cloned as Jira Issue OCPBUGS-35806. Will retitle bug to link to clone. /retitle [release-4.16] OCPBUGS-35806: Revert "Azure: add Azure specific dnsmasq ordering"

In response to [this](https://github.com/openshift/machine-config-operator/pull/4414): >This is an automated cherry-pick of #4411 > >/assign yuqi-zhang Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35806, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-35519](https://issues.redhat.com//browse/OCPBUGS-35519) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-35519](https://issues.redhat.com//browse/OCPBUGS-35519) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4414): >This is an automated cherry-pick of #4411 > >/assign yuqi-zhang Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: openshift-cherrypick-robot, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.16/OWNERS)~~ [yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci[bot] commented 1 month ago

@openshift-cherrypick-robot: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-zones 36aec89032e27aa55f4ec92fd4fdb3199dcb3924 link false /test e2e-vsphere-ovn-zones
ci/prow/e2e-vsphere-ovn-upi-zones 36aec89032e27aa55f4ec92fd4fdb3199dcb3924 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/okd-images 36aec89032e27aa55f4ec92fd4fdb3199dcb3924 link false /test okd-images

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sergiordlr commented 1 month ago

/label cherry-pick-approved

sinnykumari commented 1 month ago

@sdodson need help with getting this merged into 4.16

sergiordlr commented 1 month ago

/label qe-approved

openshift-ci-robot commented 1 month ago

@openshift-cherrypick-robot: This pull request references Jira Issue OCPBUGS-35806, which is valid.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-35519](https://issues.redhat.com//browse/OCPBUGS-35519) is in the state Verified, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-35519](https://issues.redhat.com//browse/OCPBUGS-35519) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @sergiordlr

In response to [this](https://github.com/openshift/machine-config-operator/pull/4414): >This is an automated cherry-pick of #4411 > >/assign yuqi-zhang Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sdodson commented 1 month ago

I think we decided this doesn't have to make the GA build, will check back on things after go-no-go call on Thursday.

sdodson commented 3 weeks ago

/label staff-eng-approved

openshift-ci-robot commented 3 weeks ago

@openshift-cherrypick-robot: Jira Issue OCPBUGS-35806: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35806 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4414): >This is an automated cherry-pick of #4411 > >/assign yuqi-zhang Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202406262253.p0.g6995530.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.

openshift-merge-robot commented 3 weeks ago

Fix included in accepted release 4.16.0-0.nightly-2024-06-27-032944