openshift / machine-config-operator

Apache License 2.0
244 stars 396 forks source link

OCPBUGS-35300: MCD-pull: run after network-online.target in Azure #4423

Closed yuqi-zhang closed 2 weeks ago

yuqi-zhang commented 1 month ago

This was originally reordered such that ovs-configuration was able to run when the reboot was skipped. See: https://github.com/openshift/machine-config-operator/pull/3858

This broke ARO since they require the network to be ready for the pull to happen (and generally, probably best for the network to be ready before attempting to pull the new OS image).

This fix aims to apply just to Azure, which is not ideal since it drifts the service definition, but if don't-reboot-on-metal and ARO have different dependency chains, this is the easiest middle ground.

- What I did

- How to verify it

- Description for the changelog

openshift-ci-robot commented 1 month ago

@yuqi-zhang: This pull request references Jira Issue OCPBUGS-35300, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (hlipsig+1@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4423): >This was originally reordered such that ovs-configuration was able to run when the reboot was skipped. See: https://github.com/openshift/machine-config-operator/pull/3858 > >This broke ARO since they require the network to be ready for the pull to happen (and generally, probably best for the network to be ready before attempting to pull the new OS image). > >This fix aims to apply just to Azure, which is not ideal since it drifts the service definition, but if don't-reboot-on-metal and ARO have different dependency chains, this is the easiest middle ground. > > > >**- What I did** > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 1 month ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

yuqi-zhang commented 2 weeks ago

/test e2e-azure

sdodson commented 2 weeks ago

/lgtm

openshift-ci[bot] commented 2 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sdodson, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
yuqi-zhang commented 2 weeks ago

/test e2e-hypershift

openshift-ci[bot] commented 2 weeks ago

@yuqi-zhang: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-zones c7d6ec2799237dc3678f2507b6f5e511589890b4 link false /test e2e-vsphere-ovn-zones
ci/prow/e2e-vsphere-ovn-upi-zones c7d6ec2799237dc3678f2507b6f5e511589890b4 link false /test e2e-vsphere-ovn-upi-zones

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sdodson commented 2 weeks ago

/override ci/prow/e2e-hypershift

openshift-ci[bot] commented 2 weeks ago

@sdodson: Overrode contexts on behalf of sdodson: ci/prow/e2e-hypershift

In response to [this](https://github.com/openshift/machine-config-operator/pull/4423#issuecomment-2207597135): >/override ci/prow/e2e-hypershift Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sdodson commented 2 weeks ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 2 weeks ago

@sdodson: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4423#issuecomment-2207604316): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 2 weeks ago

/retest-required

Remaining retests: 0 against base HEAD edfb19f7dd971de90d7726d7ba2ced9192ee2d52 and 2 for PR HEAD c7d6ec2799237dc3678f2507b6f5e511589890b4 in total

openshift-ci-robot commented 2 weeks ago

@yuqi-zhang: Jira Issue OCPBUGS-35300: Some pull requests linked via external trackers have merged:

The following pull requests linked via external trackers have not merged:

These pull request must merge or be unlinked from the Jira bug in order for it to move to the next state. Once unlinked, request a bug refresh with /jira refresh.

Jira Issue OCPBUGS-35300 has not been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4423): >This was originally reordered such that ovs-configuration was able to run when the reboot was skipped. See: https://github.com/openshift/machine-config-operator/pull/3858 > >This broke ARO since they require the network to be ready for the pull to happen (and generally, probably best for the network to be ready before attempting to pull the new OS image). > >This fix aims to apply just to Azure, which is not ideal since it drifts the service definition, but if don't-reboot-on-metal and ARO have different dependency chains, this is the easiest middle ground. > > > >**- What I did** > >**- How to verify it** > >**- Description for the changelog** > > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 2 weeks ago

@sdodson: new pull request created: #4453

In response to [this](https://github.com/openshift/machine-config-operator/pull/4423#issuecomment-2207604316): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sdodson commented 2 weeks ago

/jira refresh

openshift-ci-robot commented 2 weeks ago

@sdodson: Jira Issue OCPBUGS-35300: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35300 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4423#issuecomment-2208063390): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 2 weeks ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202407040511.p0.g0f53196.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.