search

openshift / machine-config-operator

Apache License 2.0
244 stars 396 forks source link

OCPBUGS-35971: disable mglru kernel feature #4425

Closed rphillips closed 3 weeks ago

rphillips commented 3 weeks ago

QE Testing procedure Confirm that node have the flag set

Before the fix,

sh-5.1# cat /sys/kernel/mm/lru_gen/enabled
0x0007

and after the fix is should look like,

sh-5.1# cat /sys/kernel/mm/lru_gen/enabled
0x0000
sdodson commented 3 weeks ago

/retitle OCPBUGS-35971: disable mglru kernel feature

openshift-ci-robot commented 3 weeks ago

@rphillips: This pull request references Jira Issue OCPBUGS-35971, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4425): > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@rphillips: This pull request references Jira Issue OCPBUGS-35971, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

No GitHub users were found matching the public email listed for the QA contact in Jira (schoudha@redhat.com), skipping review request.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4425): >QE Testing procedure >Confirm that node have the flag set > >Before the fix, >``` >sh-5.1# cat /sys/kernel/mm/lru_gen/enabled >0x0007 >``` >and after the fix is should look like, >``` >sh-5.1# cat /sys/kernel/mm/lru_gen/enabled >0x0000 >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sdodson commented 3 weeks ago

/lgtm /hold for clusterbot confirmation, I've tested the contents of the unit in an existing cluster and found it to be effective

harche commented 3 weeks ago

/lgtm

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harche, rphillips, sdodson, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sdodson commented 3 weeks ago

/hold cancel Clusterbot testing confirmed success.

openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD 612b9cd6a642a560bb48b9e8f1fa9cb4b54622ab and 2 for PR HEAD 5236644ad2c4868a90deb47745d7bf7fe322c2d2 in total

sdodson commented 3 weeks ago

vsphere, aws, and hypershift all have at least one success, moving forward. /cherry-pick release-4.16

openshift-cherrypick-robot commented 3 weeks ago

@sdodson: once the present PR merges, I will cherry-pick it on top of release-4.16 in a new PR and assign it to you.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4425#issuecomment-2186981314): >vsphere, aws, and hypershift all have at least one success, moving forward. >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci-robot commented 3 weeks ago

@rphillips: Jira Issue OCPBUGS-35971: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-35971 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4425): >QE Testing procedure >Confirm that node have the flag set > >Before the fix, >``` >sh-5.1# cat /sys/kernel/mm/lru_gen/enabled >0x0007 >``` >and after the fix is should look like, >``` >sh-5.1# cat /sys/kernel/mm/lru_gen/enabled >0x0000 >``` Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-cherrypick-robot commented 3 weeks ago

@sdodson: #4425 failed to apply on top of branch "release-4.16":

Applying: disable mglru service
.git/rebase-apply/patch:18: trailing whitespace.

.git/rebase-apply/patch:24: trailing whitespace.

warning: 2 lines add whitespace errors.
Using index info to reconstruct a base tree...
M   templates/common/_base/units/kubelet-dependencies.target.yaml
Falling back to patching base and 3-way merge...
Auto-merging templates/common/_base/units/kubelet-dependencies.target.yaml
CONFLICT (content): Merge conflict in templates/common/_base/units/kubelet-dependencies.target.yaml
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 disable mglru service
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".
In response to [this](https://github.com/openshift/machine-config-operator/pull/4425#issuecomment-2186981314): >vsphere, aws, and hypershift all have at least one success, moving forward. >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202406241812.p0.g2e1b6bc.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.