search

openshift / machine-config-operator

Apache License 2.0
245 stars 408 forks source link

OCPBUGS-28974, OCPBUGS-21628: daemon: Handle correctly OS Version for 4.1 and 4.2 bootimages #4429

Closed sinnykumari closed 3 months ago

sinnykumari commented 3 months ago

Fixes:

openshift-ci-robot commented 3 months ago

@sinnykumari: This pull request references Jira Issue OCPBUGS-28974, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4429): >Fixes: >- https://issues.redhat.com/browse/OCPBUGS-28974 >- https://issues.redhat.com/browse/OCPBUGS-21628 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sinnykumari commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@sinnykumari: This pull request references Jira Issue OCPBUGS-28974, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state ASSIGNED, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @rioliu-rh

In response to [this](https://github.com/openshift/machine-config-operator/pull/4429#issuecomment-2189093609): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
sinnykumari commented 3 months ago

We may have to do post merge verification since it hits image pull related issue when scale-up gets tested with older bootimage:

Jun 25 14:19:47 ip-10-0-64-54 sh[1474]: Trying to pull registry.build03.ci.openshift.org/ci-ln-7fgcnct/stable@sha256:d2a5c5414fbffb6212a4fdb0a471787a3bdfb77e784bbb555265288158dd41fb...time="2024-06-25T14:19:47Z" level=error msg="Error pulling image ref //registry.build03.ci.openshift.org/ci-ln-7fgcnct/stable@sha256:d2a5c5414fbffb6212a4fdb0a471787a3bdfb77e784bbb555265288158dd41fb: Digest of source image's manifest would not match destination reference"
Jun 25 14:19:47 ip-10-0-64-54 sh[1474]: Failed
Jun 25 14:19:47 ip-10-0-64-54 sh[1474]: Error: error pulling image "registry.build03.ci.openshift.org/ci-ln-7fgcnct/stable@sha256:d2a5c5414fbffb6212a4fdb0a471787a3bdfb77e784bbb555265288158dd41fb": unable to pull registry.build03.ci.openshift.org/ci-ln-7fgcnct/stable@sha256:d2a5c5414fbffb6212a4fdb0a471787a3bdfb77e784bbb555265288158dd41fb: unable to pull image: Digest of source image's manifest would not match destination reference

I think @sergiordlr saw this issue in past as well https://redhat-internal.slack.com/archives/C02CZNQHGN8/p1712169045599479?thread_ts=1712153017.929469&cid=C02CZNQHGN8

openshift-ci-robot commented 3 months ago

@sinnykumari: This pull request references Jira Issue OCPBUGS-28974, which is valid.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state POST, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @rioliu-rh

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-21628, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sergiordlr

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4429): >Fixes: >- https://issues.redhat.com/browse/OCPBUGS-28974 >- https://issues.redhat.com/browse/OCPBUGS-21628 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sinnykumari, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [sinnykumari,yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
sergiordlr commented 3 months ago

@sinnykumari is right, we can't pre-merge verify it.

Please, merge this PR without the qe-approved label and we will verify it post merge.

Thanks!

sinnykumari commented 3 months ago

Thanks Sergio! Removing hold so that verification can happen post merge /hold cancel

sinnykumari commented 3 months ago

/retest required

openshift-ci[bot] commented 3 months ago

@sinnykumari: The /retest command does not accept any targets. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/machine-config-operator/pull/4429#issuecomment-2191088358): >/retest required Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sinnykumari commented 3 months ago

/test e2e-hypershift

openshift-ci[bot] commented 3 months ago

@sinnykumari: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upi-zones 52e76fec7b63039f0a0088070f597777eb2575b0 link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-aws-ovn-upgrade-out-of-change 52e76fec7b63039f0a0088070f597777eb2575b0 link false /test e2e-aws-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
openshift-ci-robot commented 3 months ago

@sinnykumari: Jira Issue OCPBUGS-28974: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-28974 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-21628: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-21628 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4429): >Fixes: >- https://issues.redhat.com/browse/OCPBUGS-28974 >- https://issues.redhat.com/browse/OCPBUGS-21628 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202406261807.p0.g83b97d9.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.

sinnykumari commented 3 months ago

We need this to be backported until 4.13 /cherry-pick release 4.16

openshift-cherrypick-robot commented 3 months ago

@sinnykumari: cannot checkout release: error checking out "release": exit status 1 error: pathspec 'release' did not match any file(s) known to git

In response to [this](https://github.com/openshift/machine-config-operator/pull/4429#issuecomment-2196897176): >We need this to be backported until 4.13 >/cherry-pick release 4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
sinnykumari commented 3 months ago

/cherry-pick release-4.16

openshift-cherrypick-robot commented 3 months ago

@sinnykumari: new pull request created: #4445

In response to [this](https://github.com/openshift/machine-config-operator/pull/4429#issuecomment-2196995388): >/cherry-pick release-4.16 Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.