search

openshift / machine-config-operator

Apache License 2.0
244 stars 396 forks source link

OCPBUGS-36165, OCPBUGS-36166: CurrentImagePullSecret should be consumed by the MCD #4430

Closed cheesesashimi closed 3 weeks ago

cheesesashimi commented 3 weeks ago

This is a backport of https://github.com/openshift/machine-config-operator/pull/4395 into 4.16. See that PR for details around what this code does, etc.

cheesesashimi commented 3 weeks ago

/jira cherrypick OCPBUGS-34261 /jira cherrypick OCPBUGS-33913

openshift-ci-robot commented 3 weeks ago

@cheesesashimi: Jira Issue OCPBUGS-34261 has been cloned as Jira Issue OCPBUGS-36165. Will retitle bug to link to clone. /retitle OCPBUGS-36165: CurrentImagePullSecret should be consumed by the MCD

In response to [this](https://github.com/openshift/machine-config-operator/pull/4430#issuecomment-2189100483): >/jira cherrypick OCPBUGS-34261 >/jira cherrypick OCPBUGS-33913 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cheesesashimi commented 3 weeks ago

/jira cherrypick OCPBUGS-33913

openshift-ci-robot commented 3 weeks ago

@cheesesashimi: Jira Issue OCPBUGS-33913 has been cloned as Jira Issue OCPBUGS-36166. Will retitle bug to link to clone. /retitle OCPBUGS-36166: CurrentImagePullSecret should be consumed by the MCD

In response to [this](https://github.com/openshift/machine-config-operator/pull/4430#issuecomment-2189102668): >/jira cherrypick OCPBUGS-33913 Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@cheesesashimi: This pull request references Jira Issue OCPBUGS-36165, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4430): >This is a backport of https://github.com/openshift/machine-config-operator/pull/4395 into 4.16. See that PR for details around what this code does, etc. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@cheesesashimi: This pull request references Jira Issue OCPBUGS-36165, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-36166, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4430): >This is a backport of https://github.com/openshift/machine-config-operator/pull/4395 into 4.16. See that PR for details around what this code does, etc. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-ci-robot commented 3 weeks ago

@cheesesashimi: This pull request references Jira Issue OCPBUGS-36165, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

This pull request references Jira Issue OCPBUGS-36166, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4430): >This is a backport of https://github.com/openshift/machine-config-operator/pull/4395 into 4.16. See that PR for details around what this code does, etc. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cheesesashimi commented 3 weeks ago

/jira refresh

openshift-ci-robot commented 3 weeks ago

@cheesesashimi: This pull request references Jira Issue OCPBUGS-36165, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-34261](https://issues.redhat.com//browse/OCPBUGS-34261) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-34261](https://issues.redhat.com//browse/OCPBUGS-34261) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @sergiordlr

This pull request references Jira Issue OCPBUGS-36166, which is valid. The bug has been moved to the POST state.

7 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.16.0) matches configured target version for branch (4.16.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST) * release note type set to "Release Note Not Required" * dependent bug [Jira Issue OCPBUGS-33913](https://issues.redhat.com//browse/OCPBUGS-33913) is in the state ON_QA, which is one of the valid states (MODIFIED, ON_QA, VERIFIED) * dependent [Jira Issue OCPBUGS-33913](https://issues.redhat.com//browse/OCPBUGS-33913) targets the "4.17.0" version, which is one of the valid target versions: 4.17.0 * bug has dependents

Requesting review from QA contact: /cc @sergiordlr

In response to [this](https://github.com/openshift/machine-config-operator/pull/4430#issuecomment-2189138383): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cheesesashimi commented 3 weeks ago

/test e2e-gcp-op-techpreview

cheesesashimi commented 3 weeks ago

/test e2e-gcp-op-techpreview

openshift-ci[bot] commented 3 weeks ago

@cheesesashimi: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/e2e-vsphere-ovn-upi-zones a7b8ead901d0af54646c9666b2ecef8239e1171a link false /test e2e-vsphere-ovn-upi-zones
ci/prow/e2e-azure-ovn-upgrade-out-of-change a7b8ead901d0af54646c9666b2ecef8239e1171a link false /test e2e-azure-ovn-upgrade-out-of-change

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).
sergiordlr commented 3 weeks ago

/label cherry-pick-approved

openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, yuqi-zhang

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/release-4.16/OWNERS)~~ [cheesesashimi,yuqi-zhang] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 weeks ago

/retest-required

Remaining retests: 0 against base HEAD bb771f7552f287a42ebd2ec7b40589d001cd3f67 and 2 for PR HEAD a7b8ead901d0af54646c9666b2ecef8239e1171a in total

openshift-ci-robot commented 3 weeks ago

@cheesesashimi: Jira Issue OCPBUGS-36165: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36165 has been moved to the MODIFIED state.

Jira Issue OCPBUGS-36166: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36166 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4430): >This is a backport of https://github.com/openshift/machine-config-operator/pull/4395 into 4.16. See that PR for details around what this code does, etc. Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 weeks ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.16.0-202406290937.p0.geca01e9.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.

openshift-merge-robot commented 2 weeks ago

Fix included in accepted release 4.16.0-0.nightly-2024-07-01-133841