search

openshift / machine-config-operator

Apache License 2.0
244 stars 396 forks source link

adds verify-e2e target #4433

Open cheesesashimi opened 3 weeks ago

cheesesashimi commented 3 weeks ago

- What I did

While handling a tough set of merge conflicts, I noticed that under certain circumstances the e2e tests would allow syntax errors and other issues to get through. These issues would not be discovered in CI until after the ephemeral test cluster is brought up and the tests begin to run. Instead, we should perform a test compilation of the e2e tests during the verify job to rapidly identify any syntax errors. This will provide rapid and immediate feedback that something is amiss.

- How to verify it

  1. Clone this PR to your machine.
  2. Introduce a syntax error anywhere under the test/ directory.
  3. Run $ make verify which should fail.
  4. Revert the syntax error.
  5. Run $ make verify which should now succeed.

- Description for the changelog Adds a verify-e2e Makefile target for rapid CI feedback

cheesesashimi commented 3 weeks ago

/test test-verify

openshift-ci[bot] commented 3 weeks ago

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

openshift-ci[bot] commented 3 weeks ago

@cheesesashimi: The specified target(s) for /test were not found. The following commands are available to trigger required jobs:

The following commands are available to trigger optional jobs:

Use /test all to run the following jobs that were automatically triggered:

In response to [this](https://github.com/openshift/machine-config-operator/pull/4433#issuecomment-2189263244): >/test test-verify Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository.
openshift-ci[bot] commented 3 weeks ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [cheesesashimi] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
cheesesashimi commented 3 weeks ago

/test verify

openshift-ci[bot] commented 3 weeks ago

@cheesesashimi: all tests passed!

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available [here](https://git.k8s.io/community/contributors/guide/pull-requests.md). If you have questions or suggestions related to my behavior, please file an issue against the [kubernetes-sigs/prow](https://github.com/kubernetes-sigs/prow/issues/new?title=Prow%20issue:) repository. I understand the commands that are listed [here](https://go.k8s.io/bot-commands).