search

openshift / machine-config-operator

Apache License 2.0
245 stars 408 forks source link

OCPBUGS-36178: remove unnecessary e2e test TestControllerConfigStuff #4434

Closed cheesesashimi closed 3 months ago

cheesesashimi commented 3 months ago

- What I did

This test was accidentally committed and merged by mistake. Its original purpose was to assist me with writing a more in-depth test below.

- How to verify it

N/A

- Description for the changelog Removes unnecessary e2e test

openshift-ci-robot commented 3 months ago

@cheesesashimi: This pull request references Jira Issue OCPBUGS-36178, which is invalid:

Comment /jira refresh to re-evaluate validity if changes to the Jira bug are made, or edit the title of this pull request to link to a different bug.

The bug has been updated to refer to the pull request using the external bug tracker.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4434): >**- What I did** > >This test was accidentally committed and merged by mistake. Its original purpose was to assist me with writing a more in-depth test below. > >**- How to verify it** > >N/A > >**- Description for the changelog** >Removes unnecessary e2e test > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
cheesesashimi commented 3 months ago

/jira refresh

openshift-ci-robot commented 3 months ago

@cheesesashimi: This pull request references Jira Issue OCPBUGS-36178, which is valid. The bug has been moved to the POST state.

3 validation(s) were run on this bug * bug is open, matching expected state (open) * bug target version (4.17.0) matches configured target version for branch (4.17.0) * bug is in the state New, which is one of the valid states (NEW, ASSIGNED, POST)

Requesting review from QA contact: /cc @sergiordlr

In response to [this](https://github.com/openshift/machine-config-operator/pull/4434#issuecomment-2189395991): >/jira refresh Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
djoshy commented 3 months ago

/lgtm /approve

cheesesashimi commented 3 months ago

@sergiordlr I don't think this PR requires QE review since it removes an unnecessary test that shouldn't have been committed and merged in the first place.

cheesesashimi commented 3 months ago

/test unit

openshift-ci[bot] commented 3 months ago

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cheesesashimi, djoshy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files: - ~~[OWNERS](https://github.com/openshift/machine-config-operator/blob/master/OWNERS)~~ [cheesesashimi,djoshy] Approvers can indicate their approval by writing `/approve` in a comment Approvers can cancel approval by writing `/approve cancel` in a comment
openshift-ci-robot commented 3 months ago

@cheesesashimi: Jira Issue OCPBUGS-36178: All pull requests linked via external trackers have merged:

Jira Issue OCPBUGS-36178 has been moved to the MODIFIED state.

In response to [this](https://github.com/openshift/machine-config-operator/pull/4434): >**- What I did** > >This test was accidentally committed and merged by mistake. Its original purpose was to assist me with writing a more in-depth test below. > >**- How to verify it** > >N/A > >**- Description for the changelog** >Removes unnecessary e2e test > Instructions for interacting with me using PR comments are available [here](https://prow.ci.openshift.org/command-help?repo=openshift%2Fmachine-config-operator). If you have questions or suggestions related to my behavior, please file an issue against the [openshift-eng/jira-lifecycle-plugin](https://github.com/openshift-eng/jira-lifecycle-plugin/issues/new) repository.
openshift-bot commented 3 months ago

[ART PR BUILD NOTIFIER]

This PR has been included in build ose-machine-config-operator-container-v4.17.0-202406252042.p0.gafb4341.assembly.stream.el9 for distgit ose-machine-config-operator. All builds following this will include this PR.